Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Go docs: new aliases and more #843

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Update Go docs: new aliases and more #843

merged 1 commit into from
Oct 18, 2021

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Oct 18, 2021 •
edited
Loading

@chalin chalin requested review from MrAlias and a team October 18, 2021 20:08
@chalin chalin mentioned this pull request Oct 18, 2021
Closed
16 tasks
MrAlias
MrAlias approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing the trailing / is not important, right?

@chalin
Copy link
Contributor Author

chalin commented Oct 18, 2021

I'm guessing the trailing / is not important, right?

Right. (Netlify assumes a trailing slash on the first entry of a redirect rule, so we don't need it in an alias specification.)

@chalin
Copy link
Contributor Author

chalin commented Oct 18, 2021

Build is failing but it seems to be because of the hugo wrapper -- jakejarvis/hugo-extended#81.

@chalin
Copy link
Contributor Author

chalin commented Oct 18, 2021

Restarting the build a couple of times seems to have done the trick!

@chalin chalin merged commit 9927ad0 into open-telemetry:main Oct 18, 2021
@chalin chalin deleted the chalin-update-go-2021-10-18 branch October 18, 2021 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chalin @MrAlias