Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opentelemetry-specification #719

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Sep 9, 2021

Followup to #715, bringing the schemas back in line with the changes introduced by #695.

This PR was created by running the following command:

$ npm run submodule:update content-modules/opentelemetry-specification

Preview tests:

/cc @tigrannajaryan

@chalin chalin requested a review from a team September 9, 2021 13:58
@chalin
Copy link
Contributor Author

chalin commented Sep 9, 2021

This PR was created by running the following command:

$ npm run submodule:update content-modules/opentelemetry-specification

@austinlparker - we had discussed the possibility of having a single command to generate the PR from the command line. Well, this is it 😄

@chalin
Copy link
Contributor Author

chalin commented Sep 9, 2021

If we want something simpler, we can always add another script named, say update-spec so that the command would become:

$ npm run update-spec

@chalin
Copy link
Contributor Author

chalin commented Sep 9, 2021

Since this is a simple PR bringing the site back to a state that it was recently, I'm going to merge now.

@chalin chalin merged commit ccab860 into open-telemetry:main Sep 9, 2021
@chalin chalin deleted the chalin-otel-spec-update-2021-09-09 branch September 9, 2021 14:13
@chalin
Copy link
Contributor Author

chalin commented Sep 10, 2021

If we want something simpler, we can always add another script named, say update-spec so that the command would become:

$ npm run update-spec

FYI, #725 adds an npm script named schemas:update.

tigrannajaryan added a commit to tigrannajaryan/opentelemetry.io that referenced this pull request Oct 1, 2021
This PR is done by following instructions posted at
open-telemetry#719
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant