Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending with custom manual instrumentation #5789

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

zeitlinger
Copy link
Member

Fixes #5713

@zeitlinger zeitlinger self-assigned this Dec 13, 2024
@zeitlinger zeitlinger requested a review from a team as a code owner December 13, 2024 14:27
@opentelemetrybot opentelemetrybot requested review from a team December 13, 2024 14:27
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

content/en/docs/zero-code/java/agent/annotations.md Outdated Show resolved Hide resolved
content/en/docs/zero-code/java/agent/api.md Outdated Show resolved Hide resolved
content/en/docs/zero-code/java/spring-boot-starter/api.md Outdated Show resolved Hide resolved
@zeitlinger
Copy link
Member Author

@svrnm can you check?

Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing, I am not sure if api is the right name for that, since we do not even mention "api" in the title, description, so either we do that, e.g. "Adding custom instrumentations with the API" or we rename the file to something like "extending-instrumentation.md" as well. wdyt?

@zeitlinger
Copy link
Member Author

One more thing, I am not sure if api is the right name for that, since we do not even mention "api" in the title, description, so either we do that, e.g. "Adding custom instrumentations with the API" or we rename the file to something like "extending-instrumentation.md" as well. wdyt?

it's API to separate it from annotations - which also extend

@zeitlinger
Copy link
Member Author

@svrnm please check again

Comment on lines +1 to +6
---
title: Extending with custom manual instrumentation using the OpenTelemetry API
linkTitle: Extending instrumentation
description: Extending a Java agent with custom manual instrumentation.
weight: 21
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the title is now longer then the description, here is a proposal

Suggested change
---
title: Extending with custom manual instrumentation using the OpenTelemetry API
linkTitle: Extending instrumentation
description: Extending a Java agent with custom manual instrumentation.
weight: 21
---
---
title: Extending instrumentations with the API
linkTitle: Extend with the API
description: Use the OpenTelemetry API in combination with the Java agent to extend the automatically generated telemetry with custom instrumentations
weight: 21
---

@chalin @jack-berg can you take a look as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your proposal LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

how to get a meter/tracer in Java agent or spring stater
3 participants