Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new blog by OTel CI/CD SIG - Repost from cncf.io/blogs #5718
base: main
Are you sure you want to change the base?
new blog by OTel CI/CD SIG - Repost from cncf.io/blogs #5718
Changes from all commits
51ab31c
0341335
9ec8358
1a33530
2bb0d08
3a6a14a
021ab69
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a syndicated article from the CNCF.io blog, I'd rather not change wording unless meaningful, and "need vs. needing" looks more like styling IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a syndicated article from the CNCF.io blog, I'd rather not change wording unless meaningful.
In particular when positioning the project under the CNCF, we should align with the cncf.io.
Check warning on line 58 in content/en/blog/2024/otel-cicd-sig/index.md
GitHub Actions / SPELLING check
Check warning on line 66 in content/en/blog/2024/otel-cicd-sig/index.md
GitHub Actions / SPELLING check
Check warning on line 68 in content/en/blog/2024/otel-cicd-sig/index.md
GitHub Actions / SPELLING check
Check warning on line 68 in content/en/blog/2024/otel-cicd-sig/index.md
GitHub Actions / SPELLING check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are terms and should IMO be capitalized. please revisit and refer to guidance if otherwise stated.
Check warning on line 69 in content/en/blog/2024/otel-cicd-sig/index.md
GitHub Actions / SPELLING check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from what I understand this image is by SLSA? We need to add a license note to that image, please review the project's license to find out what is needed for that (it seems to be custom so I can not provide guidance):
https://github.com/slsa-framework/slsa/blob/main/LICENSE.md
depending on the order of things, we might follow #5681 already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a lawyer, and thus this isn't legal advice. The way I read their license is that the image needs to be attributed to SLSA at the respective version.
Source: https://github.com/slsa-framework/slsa?tab=License-1-ov-file#readme
Image was taken from https://slsa.dev/spec/v1.0/images/supply-chain-threats.svg - source code: https://github.com/slsa-framework/slsa/blob/main/docs/images/supply-chain-threats.svg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a syndicated article from the CNCF.io blog, I'd rather not change wording unless meaningful, and "via" vs "using" seems pure styling IMO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a syndicated article from the CNCF.io blog, I'd rather not change wording unless meaningful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a syndicated article from the CNCF.io blog, I'd rather not change wording unless meaningful.
Check warning on line 82 in content/en/blog/2024/otel-cicd-sig/index.md
GitHub Actions / SPELLING check
Check warning on line 92 in content/en/blog/2024/otel-cicd-sig/index.md
GitHub Actions / SPELLING check
Check warning on line 97 in content/en/blog/2024/otel-cicd-sig/index.md
GitHub Actions / SPELLING check
Check warning on line 98 in content/en/blog/2024/otel-cicd-sig/index.md
GitHub Actions / SPELLING check
Check warning on line 98 in content/en/blog/2024/otel-cicd-sig/index.md
GitHub Actions / SPELLING check