-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
collector: update internal logs config to include OTLP export #5702
collector: update internal logs config to include OTLP export #5702
Conversation
This adds the details to emit the Collector's internal logs via OTLP. Fixes open-telemetry#5680 Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess the table above with all the config options also needs some updating
@open-telemetry/collector-approvers PTAL
Are those changes to the table relevant for this PR or are they independent? If they are related, can you tag the lines of code what needs to be changed, otherwise can you raise an issue with what needs to be changed? TY |
Yes, the changes are relevant for this PR. New config options were added for the underlying feature and I think they should be reflected in the table as well. Probably just appended to the table here: https://github.com/open-telemetry/opentelemetry.io/pull/5702/files#diff-a03cac27414e8bfcdad01d15e4488809ea60503b6199040c78ef46d3f178f96dR88 |
sounds good :) |
does the follow up issue exist already? |
opened #5721 |
This adds the details to emit the Collector's internal logs via OTLP.
Fixes #5680