Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collector: update internal logs config to include OTLP export #5702

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

codeboten
Copy link
Contributor

This adds the details to emit the Collector's internal logs via OTLP.

Fixes #5680

This adds the details to emit the Collector's internal logs via OTLP.

Fixes open-telemetry#5680

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten requested a review from a team as a code owner November 27, 2024 20:22
@opentelemetrybot opentelemetrybot requested review from a team and atoulme and removed request for a team November 27, 2024 20:22
Signed-off-by: Alex Boten <[email protected]>
@opentelemetrybot opentelemetrybot requested a review from a team November 27, 2024 21:34
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess the table above with all the config options also needs some updating

@svrnm svrnm added the sig-approval-missing Co-owning SIG didn't provide an approval label Nov 28, 2024
@svrnm
Copy link
Member

svrnm commented Nov 28, 2024

@open-telemetry/collector-approvers PTAL

i guess the table above with all the config options also needs some updating

Are those changes to the table relevant for this PR or are they independent? If they are related, can you tag the lines of code what needs to be changed, otherwise can you raise an issue with what needs to be changed? TY

@mowies
Copy link
Member

mowies commented Nov 28, 2024

Yes, the changes are relevant for this PR. New config options were added for the underlying feature and I think they should be reflected in the table as well. Probably just appended to the table here: https://github.com/open-telemetry/opentelemetry.io/pull/5702/files#diff-a03cac27414e8bfcdad01d15e4488809ea60503b6199040c78ef46d3f178f96dR88

@codeboten
Copy link
Contributor Author

@mowies @svrnm if you're ok with this, i would like to file a separate issue to track this, as the options for exporting the collector's internal telemetry will need to be documented for metrics and traces as well.

@opentelemetrybot opentelemetrybot requested a review from a team December 3, 2024 00:14
@mowies
Copy link
Member

mowies commented Dec 3, 2024

sounds good :)

@svrnm
Copy link
Member

svrnm commented Dec 3, 2024

@mowies @svrnm if you're ok with this, i would like to file a separate issue to track this, as the options for exporting the collector's internal telemetry will need to be documented for metrics and traces as well.

works for me!

@svrnm svrnm removed the sig-approval-missing Co-owning SIG didn't provide an approval label Dec 3, 2024
@svrnm svrnm added this pull request to the merge queue Dec 3, 2024
Merged via the queue into open-telemetry:main with commit 449f234 Dec 3, 2024
17 checks passed
@mowies
Copy link
Member

mowies commented Dec 3, 2024

does the follow up issue exist already?

@codeboten
Copy link
Contributor Author

opened #5721

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add docs for updated collector internal telemetry features
4 participants