Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configuration.md #5654

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Update configuration.md #5654

merged 3 commits into from
Dec 12, 2024

Conversation

shalk
Copy link
Contributor

@shalk shalk commented Nov 21, 2024

update filter processor
@shalk shalk requested a review from a team as a code owner November 21, 2024 03:02
@opentelemetrybot opentelemetrybot requested review from a team and TylerHelmuth and removed request for a team November 21, 2024 03:02
@svrnm
Copy link
Member

svrnm commented Nov 21, 2024

thanks @shalk!

@open-telemetry/collector-approvers PTAL

@svrnm svrnm added the sig-approval-missing Co-owning SIG didn't provide an approval label Dec 11, 2024
@svrnm
Copy link
Member

svrnm commented Dec 11, 2024

@open-telemetry/collector-approvers PTAL!

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@svrnm
Copy link
Member

svrnm commented Dec 12, 2024

/fix:all

@opentelemetrybot
Copy link
Collaborator

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@svrnm svrnm enabled auto-merge December 12, 2024 11:41
@opentelemetrybot opentelemetrybot requested a review from a team December 12, 2024 11:42
@svrnm svrnm added this pull request to the merge queue Dec 12, 2024
Merged via the queue into open-telemetry:main with commit 1d2a6fa Dec 12, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig:collector sig-approval-missing Co-owning SIG didn't provide an approval
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants