Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opentelemetry-proto version to v1.4.0 #5650

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

opentelemetrybot
Copy link
Collaborator

@opentelemetrybot opentelemetrybot requested a review from a team as a code owner November 20, 2024 21:16
@chalin chalin self-assigned this Nov 20, 2024
Comment on lines -57 to +59
### [Tracing][]
### Tracing

- [Specification][tracing]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: we shouldn't have links in headers, especially when the entire header is a link, because that breaks the ToC entry. So I move the reference to the spec section into the body of the section. I did this change for each signal section.

@chalin
Copy link
Contributor

chalin commented Nov 21, 2024

@tigrannajaryan @bogdandrutu @trask - PTAL to the spec status page updates, in particular:

Is there a group I can CC in this sort of situation? Maybe @open-telemetry/spec-sponsors ?

/cc @open-telemetry/docs-maintainers

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if someone from the OTLP and or more general specs teams can approve the changes to the status page that I submitted.

@tigrannajaryan
Copy link
Member

Is there a group I can CC in this sort of situation? Maybe @open-telemetry/spec-sponsors ?

Yes, that sounds good.

@chalin chalin force-pushed the opentelemetrybot/auto-update-opentelemetry-proto-v1.4.0 branch from 720dcc9 to 3e3b200 Compare November 21, 2024 07:09
@chalin chalin merged commit ddd8d43 into main Nov 21, 2024
19 checks passed
@chalin chalin deleted the opentelemetrybot/auto-update-opentelemetry-proto-v1.4.0 branch November 21, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants