Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add confmap provider to registry.json #5637

Merged
merged 10 commits into from
Nov 22, 2024
Merged

Conversation

jackgopack4
Copy link
Contributor

@jackgopack4 jackgopack4 commented Nov 19, 2024

As mentioned in #5387, there are more components that are compatible with the OpenTelemetry Collector.
These include confmap.Converter and confmap.Provider types.

confmap.Converter: open-telemetry/opentelemetry-collector#11582

confmap.Provider: open-telemetry/opentelemetry-collector#4567

There are currently five confmap.Providers that are maintained in the OpenTelemetry Collector core repository and while there is only one Converter there and it is deprecated, there are vendors that make use of converters and it is possible they would choose to publish them in the registry once this is available.

As I am not super familiar with the registry and changes necessary to update the same, I may have missed file(s) that need to be changed and will happily make these changes if suggested.

Additionally, I don't feel strongly about calling them "confmap converter" vs. "converter" or provider, but it seemed slightly more descriptive. Open to feedback there as well.

@jackgopack4
Copy link
Contributor Author

I will also plan to submit a separate PR to add the existing five confmap.providers to the registry once this change is approved.

@jackgopack4 jackgopack4 marked this pull request as ready for review November 19, 2024 15:45
@jackgopack4 jackgopack4 requested a review from a team as a code owner November 19, 2024 15:45
@svrnm
Copy link
Member

svrnm commented Nov 19, 2024

I will also plan to submit a separate PR to add the existing five confmap.providers to the registry once this change is approved.

Can you put all of them in one PR? Makes it easier to validate things and how we are going to name those values.

@svrnm svrnm added the registry label Nov 19, 2024
@jackgopack4
Copy link
Contributor Author

Can you put all of them in one PR? Makes it easier to validate things and how we are going to name those values.

Yes, done.

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, see some questions and suggestions inlined

data/registry-schema.json Outdated Show resolved Hide resolved
data/registry/collector-confmap-provider-envprovider.yml Outdated Show resolved Hide resolved
@jackgopack4 jackgopack4 changed the title add confmap converter and confmap provider to registry.json add confmap provider to registry.json Nov 21, 2024
@svrnm svrnm added this pull request to the merge queue Nov 22, 2024
@svrnm
Copy link
Member

svrnm commented Nov 22, 2024

thanks @jackgopack4

Merged via the queue into open-telemetry:main with commit 2219eb4 Nov 22, 2024
18 checks passed
@jackgopack4
Copy link
Contributor Author

jackgopack4 commented Nov 22, 2024

ah shoot, this shows "confmap providers" as the yaml tag; is there any way to have the type listed as "Confmap provider" in the dropdown but show "providers" in the sample manifest?

Screenshot 2024-11-22 at 11 07 07 AM

Alternatively I can just change the name to "provider" instead of "confmap provider"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants