Disable code-excerpting from Go getting-started #5630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 18, 2024
jack-berg
approved these changes
Nov 18, 2024
svrnm
requested changes
Nov 19, 2024
There was a problem hiding this comment.
open-telemetry/opentelemetry-go-contrib#6300 is ongoing, so we could fix it that way, but I am fine with temporarily disabling it and re-enabling it when this work is done -- @open-telemetry/go-approvers: are you OK with this?
LGTM |
pellared
approved these changes
Nov 19, 2024
dmathieu
approved these changes
Nov 19, 2024
svrnm
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run code-excerpts. (This will help make @jack-berg and the Java SIG's lives easier :)).