Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Ensure that htmltest-config warnings fail GH check #5612

Merged
merged 3 commits into from
Nov 15, 2024
Merged

[CI] Ensure that htmltest-config warnings fail GH check #5612

merged 3 commits into from
Nov 15, 2024

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Nov 15, 2024

  • Ensures that when scripts/htmltest-config.pl reports a warning, that it gets caught by the GH link-check workflow
  • As it stands, this PR should fail until I fit the pt docs index. Let's see if the check catches the warning now.

@chalin chalin added the CI/infra CI & infrastructure label Nov 15, 2024
@chalin chalin requested a review from a team as a code owner November 15, 2024 14:39
@chalin
Copy link
Contributor Author

chalin commented Nov 15, 2024

Good, the warning is being caught, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/11858217525/job/33048535443?pr=5612:

Run scripts/check-build-log.sh
WARNINGs or ERRORs found in build log:
WARNING: Unrecognized htmltest IgnoreDirs config from front matter in file 'content/pt/docs/_index.md': IgnoreDirs: {}
npm warn exec The following package was not found and will be installed: [email protected]

@opentelemetrybot opentelemetrybot requested review from a team November 15, 2024 14:46
@chalin chalin marked this pull request as draft November 15, 2024 14:46
@chalin chalin marked this pull request as ready for review November 15, 2024 14:56
@chalin chalin force-pushed the chalin-im-ci-warnings-2024-11-15 branch from 980d887 to 76902b8 Compare November 15, 2024 15:05
@chalin chalin mentioned this pull request Nov 15, 2024
Merged
@chalin chalin merged commit ccfc7d6 into open-telemetry:main Nov 15, 2024
17 checks passed
@chalin chalin deleted the chalin-im-ci-warnings-2024-11-15 branch November 15, 2024 16:02
@chalin chalin mentioned this pull request Nov 15, 2024
Merged
drewby pushed a commit to drewby/opentelemetry.io that referenced this pull request Nov 21, 2024
@chalin @drewby
[CI] Ensure that htmltest-config warnings fail GH check (open-telemet…
8e2f28a 
…ry#5612)
drewby pushed a commit to drewby/opentelemetry.io that referenced this pull request Dec 5, 2024
@chalin @drewby
[CI] Ensure that htmltest-config warnings fail GH check (open-telemet…
6ccc887 
…ry#5612)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svrnm svrnm svrnm approved these changes

Assignees
No one assigned
Labels
CI/infra CI & infrastructure lang:pt
Projects
SIG Comms: Docs Translation
Status: Done
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chalin @svrnm