Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OddDotNet registry files #5576

Closed

Conversation

DoubleTK
Copy link
Contributor

@DoubleTK DoubleTK commented Nov 9, 2024

I'm requesting to add OddDotNet and the CSharp client to the registry.

@DoubleTK DoubleTK requested a review from a team as a code owner November 9, 2024 01:39
Copy link

linux-foundation-easycla bot commented Nov 9, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@cartermp
Copy link
Contributor

/fix:all

@opentelemetrybot
Copy link
Collaborator

@opentelemetrybot
Copy link
Collaborator

fix:all failed or was cancelled. For details, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/11766713320.

@DoubleTK
Copy link
Contributor Author

/fix:htmltest-config

@opentelemetrybot
Copy link
Collaborator

You triggered fix:htmltest-config action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/11771629503

@opentelemetrybot
Copy link
Collaborator

fix:htmltest-config was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@DoubleTK
Copy link
Contributor Author

/fix:all

@opentelemetrybot
Copy link
Collaborator

@opentelemetrybot
Copy link
Collaborator

fix:all failed or was cancelled. For details, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/11771653347.

@svrnm
Copy link
Member

svrnm commented Nov 11, 2024

@DoubleTK do not worry about the CI checks failing, we can help you with that for merging the PR

data/registry/otel-odddotnet.yml Outdated Show resolved Hide resolved
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few more comments

data/registry/otel-odddotnet.yml Outdated Show resolved Hide resolved
data/registry/otel-odddotnet.yml Outdated Show resolved Hide resolved
data/registry/tools-odddotnet-client-dotnet.yml Outdated Show resolved Hide resolved
@svrnm
Copy link
Member

svrnm commented Nov 13, 2024

/fix:htmltest-config

@opentelemetrybot
Copy link
Collaborator

You triggered fix:htmltest-config action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/11818285987

@opentelemetrybot
Copy link
Collaborator

fix:htmltest-config was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@svrnm
Copy link
Member

svrnm commented Nov 13, 2024

@DoubleTK can you update the PR to be in sync with the base branch?

Note: Creating PRs from an ORG account like https://github.com/OddDotNet/ does not allow maintainers to edit your PR, so a lot of our automation does not work. Therefor for future PRs I recommend you fork from your user handle (DoubleTK) and push your PRs from there.

@DoubleTK
Copy link
Contributor Author

@DoubleTK can you update the PR to be in sync with the base branch?

Note: Creating PRs from an ORG account like https://github.com/OddDotNet/ does not allow maintainers to edit your PR, so a lot of our automation does not work. Therefor for future PRs I recommend you fork from your user handle (DoubleTK) and push your PRs from there.

Ah, that's good to know, I wasn't aware of that limitation. Thank you for the info, I'll make sure to do that next time. Updating branch with latest main now.

@svrnm
Copy link
Member

svrnm commented Nov 14, 2024

@DoubleTK can you run npm run fix:all locally and update the changes?

@DoubleTK
Copy link
Contributor Author

@DoubleTK can you run npm run fix:all locally and update the changes?

I did this, and it ran mostly successfully except for the git submodule update step: "fatal: destination path '/Users/tylerkenna/Projects/opentelemetry.io/content-modules/opentelemetry-go' already exists and is not an empty directory."

Despite running the fix:all command, there were no changes detected, so nothing to push.

Would it be easier for me to abandon this PR and re-open under my personal account? In the meantime, I'll try to run that failing "BUILD and CHECK LINKS" step again here and see if that resolves it.

@DoubleTK
Copy link
Contributor Author

/fix:htmltest-config

@opentelemetrybot
Copy link
Collaborator

You triggered fix:htmltest-config action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/11843149359

@opentelemetrybot
Copy link
Collaborator

fix:htmltest-config was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@svrnm
Copy link
Member

svrnm commented Nov 15, 2024

@DoubleTK the issue is that you need to have your URLs added to the refcache. Since we can not edit this PR for you, there are 2 options:

  • run npm run fix:refcache locally and commit the changes
  • make this PR editable, following these instructions or re-raise the PR using a non-org handle

@DoubleTK
Copy link
Contributor Author

@DoubleTK the issue is that you need to have your URLs added to the refcache. Since we can not edit this PR for you, there are 2 options:

  • run npm run fix:refcache locally and commit the changes
  • make this PR editable, following these instructions or re-raise the PR using a non-org handle

I think I'm going to take that second option and redo this using my personal account rather than org. I'll get that PR created first, and then paste the link here and abandon this PR.

@DoubleTK
Copy link
Contributor Author

Okay I've created a new PR using my personal to allow for maintainer edits. Here's the link:

#5617.

Thank you again for your help and patience, I appreciate it.

@DoubleTK DoubleTK closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants