-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OddDotNet registry files #5576
Add OddDotNet registry files #5576
Conversation
/fix:all |
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/11766713320 |
fix:all failed or was cancelled. For details, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/11766713320. |
/fix:htmltest-config |
You triggered fix:htmltest-config action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/11771629503 |
IMPORTANT: (RE-)RUN
|
/fix:all |
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/11771653347 |
fix:all failed or was cancelled. For details, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/11771653347. |
@DoubleTK do not worry about the CI checks failing, we can help you with that for merging the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few more comments
Co-authored-by: Severin Neumann <[email protected]>
Co-authored-by: Severin Neumann <[email protected]>
/fix:htmltest-config |
You triggered fix:htmltest-config action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/11818285987 |
IMPORTANT: (RE-)RUN
|
@DoubleTK can you update the PR to be in sync with the base branch? Note: Creating PRs from an ORG account like https://github.com/OddDotNet/ does not allow maintainers to edit your PR, so a lot of our automation does not work. Therefor for future PRs I recommend you fork from your user handle (DoubleTK) and push your PRs from there. |
Ah, that's good to know, I wasn't aware of that limitation. Thank you for the info, I'll make sure to do that next time. Updating branch with latest main now. |
@DoubleTK can you run |
I did this, and it ran mostly successfully except for the Despite running the fix:all command, there were no changes detected, so nothing to push. Would it be easier for me to abandon this PR and re-open under my personal account? In the meantime, I'll try to run that failing "BUILD and CHECK LINKS" step again here and see if that resolves it. |
/fix:htmltest-config |
You triggered fix:htmltest-config action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/11843149359 |
IMPORTANT: (RE-)RUN
|
@DoubleTK the issue is that you need to have your URLs added to the refcache. Since we can not edit this PR for you, there are 2 options:
|
I think I'm going to take that second option and redo this using my personal account rather than org. I'll get that PR created first, and then paste the link here and abandon this PR. |
Okay I've created a new PR using my personal to allow for maintainer edits. Here's the link: Thank you again for your help and patience, I appreciate it. |
I'm requesting to add OddDotNet and the CSharp client to the registry.