Updated summary and table of internal telemetry #5567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opentelemetrybot
requested review from
a team and
bogdandrutu
and removed request for
a team
chalin
force-pushed
the
5483-internal-metrics-update
branch
from
1e6dc53 to
0bb3614
Compare
theletterf
requested changes
Nov 10, 2024
evan-bradley
approved these changes
Nov 19, 2024
|
@theletterf please re-review |
theletterf
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rewrote the "Values observable with internal metrics" section of the "Collector > Internal telemetry" page to accurately summarize existing telemetry instead of being partly wishful thinking. This should resolve #5483.
While doing that, I noticed that the table below was also inaccurate to the telemetry currently implemented in the Collector, so I updated it. (This involved replacing the
processor_accepted/dropped_*metrics byprocessor_incoming/outgoing_items, and putting theprocessor_batchmetrics under the correct level.)I also added a note below the table which may be helpful in understanding it. It may be enough to resolve #5468. I will remove it if it is deemed unnecessary.