[CI] Don't check links on build #5549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
postbuildprocessing, which currently does link checking. We don't look anything for PRs since GH actions check links anyways. For more details, read below.Context & discussion: I used to think that it was useful to have the links checked (esp. for production builds), so that we could track down issues by inspecting logs. And we're waiting other GH workflow checks in the case of PRs anyways. I've changed my mind. We can debug production build glitches locally, if ever they occur. And for PR builds, it'll be nice to get previews faster.