update pull request template #5545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: svrnm <[email protected]>
tiffany76
approved these changes
Nov 7, 2024
Co-authored-by: Tiffany Hrabusa <[email protected]>
chalin
reviewed
Nov 8, 2024
There was a problem hiding this comment.
Whatever suggestions you choose to adopt in #5544 (review) should be incorporated here too.
Signed-off-by: svrnm <[email protected]>
|
/fix:format |
cartermp
approved these changes
Nov 11, 2024
|
You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/11785602735 |
|
IMPORTANT: (RE-)RUN
|
cartermp
approved these changes
Nov 11, 2024
|
Will take this one in as-is, it looks good and is an improvement over the other. |
drewby
pushed a commit
to drewby/opentelemetry.io
that referenced
this pull request
Nov 21, 2024
Signed-off-by: svrnm <[email protected]> Co-authored-by: Tiffany Hrabusa <[email protected]> Co-authored-by: opentelemetrybot <[email protected]> Co-authored-by: Phillip Carter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the pull request template to ask the contributor for sharing some details on their PR. It also let's the contributor know about CI checks, how they can address potential issues and that it is finally not their responsibility to have them fixed perfectly.