Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh] Add concepts/signals/_index.md #5521

Merged
merged 1 commit into from
Nov 28, 2024
Merged

[zh] Add concepts/signals/_index.md #5521

merged 1 commit into from
Nov 28, 2024

Conversation

my-git9
Copy link
Member

@my-git9 my-git9 commented Nov 4, 2024

content/zh/docs/concepts/signals/_index.md

@my-git9 my-git9 requested a review from a team as a code owner November 4, 2024 16:19
@opentelemetrybot opentelemetrybot requested review from a team November 4, 2024 16:20
windsonsea
windsonsea reviewed Nov 5, 2024
View reviewed changes
Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI log provides an error:

HASH	ERROR	content/zh/docs/concepts/signals/_index.md: git diff error (128)
or invalid hash a0ac78ec4ec9c360ea8f86481cf01bf2b82140f1. For details, use -v.

content/zh/docs/concepts/signals/_index.md Outdated Show resolved Hide resolved
@opentelemetrybot opentelemetrybot requested a review from a team November 7, 2024 23:47
chalin
chalin reviewed Nov 7, 2024
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@my-git9:

  • Ensure that you rebase your PR and force push your updates.
  • The hash code you use must be a valid hash code. You can use the current HEAD, e7c30e9, as of the time of writing this.
  • Also address the other GitHub action failures (file format and markdown linter)

@opentelemetrybot opentelemetrybot requested review from a team November 8, 2024 00:50
@svrnm
Copy link
Member

svrnm commented Nov 21, 2024

@open-telemetry/docs-zh-approvers PTAL!

@opentelemetrybot opentelemetrybot requested a review from a team November 27, 2024 13:19
@svrnm svrnm added this pull request to the merge queue Nov 28, 2024
Merged via the queue into open-telemetry:main with commit dc21cc2 Nov 28, 2024
17 checks passed
vitorvasc pushed a commit to vitorvasc/opentelemetry.io that referenced this pull request Nov 28, 2024
@my-git9 @vitorvasc
[zh] Add concepts/signals/_index.md (open-telemetry#5521)
ec0aea4 
Signed-off-by: xin.li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windsonsea windsonsea windsonsea approved these changes

@svrnm svrnm svrnm approved these changes

@chalin chalin Awaiting requested review from chalin

@reyang reyang Awaiting requested review from reyang

Assignees
No one assigned
Labels
lang:zh
Projects
SIG Comms: Docs Translation
Status: Done
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@my-git9 @svrnm @chalin @reyang @windsonsea