Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ThrottlingTroll to the list of instrumented libraries #5494

Merged
merged 8 commits into from
Nov 4, 2024

Conversation

scale-tone
Copy link
Contributor

No description provided.

@scale-tone scale-tone requested a review from a team as a code owner October 28, 2024 19:37
Copy link

linux-foundation-easycla bot commented Oct 28, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@cartermp
Copy link
Contributor

cartermp commented Nov 2, 2024

/fix:all

@opentelemetrybot
Copy link
Collaborator

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@cartermp cartermp enabled auto-merge November 2, 2024 22:52
@cartermp cartermp added this pull request to the merge queue Nov 3, 2024
@chalin chalin removed this pull request from the merge queue due to a manual request Nov 3, 2024
.htmltest.yml Outdated
@@ -13,6 +13,7 @@ IgnoreDirs:
- ^ja/docs/concepts/instrumentation/libraries/
# TODO drop next line after https://github.com/open-telemetry/opentelemetry.io/issues/5423 is fixed for pt pages:
- ^pt/docs/concepts/instrumentation/libraries/
- ^blog/(\d+/)?page/\d+
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be no change to this file. I'll undo it and investigate later.

auto-merge was automatically disabled November 4, 2024 15:12

Head branch was pushed to by a user without write access

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@chalin
Copy link
Contributor

chalin commented Nov 4, 2024

/fix:format

@opentelemetrybot
Copy link
Collaborator

@opentelemetrybot
Copy link
Collaborator

fix:format was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@chalin
Copy link
Contributor

chalin commented Nov 4, 2024

GH workflows seem stuck again. Will just merge since we have enough approvals already and Severin's comment has been addressed.

@chalin chalin merged commit 34b0ddd into open-telemetry:main Nov 4, 2024
4 of 5 checks passed
@scale-tone
Copy link
Contributor Author

Great, thank you, folks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants