-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Libraries page #5480
Libraries page #5480
Conversation
@DIANAAJAMBO this PR still contains changes to the registry, can you double check? |
@svrnm I made an error to work with the main branch from the start. So when i created a branch from my main, it came with all my past commits. I realize i should have kept one original branch without any commits and worked with the sub branches for both contributions. |
You still should be able to fix that, it's just some work. What I often do in such a situation is the following:
The habit you have to get into is having one branch per pull request, it's a learning curve but eventually it helps you to work on multiple things simultaneously. |
This is very detailed. Thank you. Let me execute this. |
0cdd064
to
db93a09
Compare
Hello @svrnm , I’ve successfully fixed the commit history, so there’s now a single commit reflecting the changes to the libraries page. Thank you for the advice, it was a huge help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DIANAAJAMBO: move the image added by this PR to content/en/docs/concepts/instrumentation
.
I added an image that compares native instrumentation and instrumentation libraries to enhance the explanation in the "Libraries" section.
I designed the image using figma and then added it to the images folder under "static" folder.
This was in relation to issue #5355