-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gateway deployment arch #5452
Add Gateway deployment arch #5452
Conversation
thanks @dineshg13 @open-telemetry/collector-approvers PTAL! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example is very k8s-specific and comes with a lot of prerequisites that are not yet set. I think it's a great addition to the documentation but it needs to explain much more of the details it brings along
…eway-deployment-example
….com:dineshg13/opentelemetry.io into dinesh.gurumurthy/gateway-deployment-example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apologies for the delay I was out of office, thanks for addressing my feedback. I spend some time thinking about this and provided some more feedback. Overall it's an important addition to the docs but we need to be much clearer why such a combined deployment is necessary.
content/en/docs/collector/deployment/gateway/otel-gateway-arch.svg
Outdated
Show resolved
Hide resolved
Co-authored-by: Severin Neumann <[email protected]>
@svrnm thanks for the feedback. I have updated the diagram + description as suggested. Please take a look. |
thanks @dineshg13! @open-telemetry/collector-approvers / @songy23 please re-review, since I requested some major changes to this PR and I wanted to make sure that it still is OK with you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(https://deploy-preview-5452--opentelemetry.netlify.app/docs/collector/deployment/gateway/#combined-deployment-of-collectors-as-agents-and-gateways for other collector approvers if anyone is interested in reviewing)
This PR updates Gateway deployment with an architecture example and the caveats that we need to be aware of when running the collector in Gateway mode.