Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gateway deployment arch #5452

Conversation

dineshg13
Copy link
Member

@dineshg13 dineshg13 commented Oct 21, 2024

This PR updates Gateway deployment with an architecture example and the caveats that we need to be aware of when running the collector in Gateway mode.

@opentelemetrybot opentelemetrybot requested review from a team and atoulme and removed request for a team October 21, 2024 22:28
@opentelemetrybot opentelemetrybot requested a review from a team October 22, 2024 01:08
@dineshg13 dineshg13 marked this pull request as ready for review October 22, 2024 14:21
@dineshg13 dineshg13 requested a review from a team as a code owner October 22, 2024 14:21
@svrnm
Copy link
Member

svrnm commented Oct 23, 2024

thanks @dineshg13

@open-telemetry/collector-approvers PTAL!

@opentelemetrybot opentelemetrybot requested a review from a team October 24, 2024 14:09
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@opentelemetrybot opentelemetrybot requested a review from a team October 24, 2024 16:42
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example is very k8s-specific and comes with a lot of prerequisites that are not yet set. I think it's a great addition to the documentation but it needs to explain much more of the details it brings along

content/en/docs/collector/deployment/gateway/index.md Outdated Show resolved Hide resolved
content/en/docs/collector/deployment/gateway/index.md Outdated Show resolved Hide resolved
content/en/docs/collector/deployment/gateway/index.md Outdated Show resolved Hide resolved
content/en/docs/collector/deployment/gateway/index.md Outdated Show resolved Hide resolved
content/en/docs/collector/deployment/gateway/index.md Outdated Show resolved Hide resolved
content/en/docs/collector/deployment/gateway/index.md Outdated Show resolved Hide resolved
content/en/docs/collector/deployment/gateway/index.md Outdated Show resolved Hide resolved
@dineshg13 dineshg13 requested a review from svrnm October 29, 2024 16:23
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apologies for the delay I was out of office, thanks for addressing my feedback. I spend some time thinking about this and provided some more feedback. Overall it's an important addition to the docs but we need to be much clearer why such a combined deployment is necessary.

content/en/docs/collector/deployment/gateway/index.md Outdated Show resolved Hide resolved
content/en/docs/collector/deployment/gateway/index.md Outdated Show resolved Hide resolved
content/en/docs/collector/deployment/gateway/index.md Outdated Show resolved Hide resolved
@dineshg13
Copy link
Member Author

@svrnm thanks for the feedback. I have updated the diagram + description as suggested. Please take a look.

@svrnm svrnm requested a review from songy23 November 4, 2024 18:31
@svrnm
Copy link
Member

svrnm commented Nov 4, 2024

thanks @dineshg13!

@open-telemetry/collector-approvers / @songy23 please re-review, since I requested some major changes to this PR and I wanted to make sure that it still is OK with you

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svrnm svrnm added this pull request to the merge queue Nov 5, 2024
Merged via the queue into open-telemetry:main with commit 5584ba7 Nov 5, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants