Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n, CI] How to deal with broken links in non-en pages when updating en pages #5448

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Oct 21, 2024

Preview: https://deploy-preview-5448--opentelemetry.netlify.app/docs/contributing/localization/#when-link-checking-fails-for-non-english-pages

@chalin chalin added CI/infra CI & infrastructure i18n internationalization labels Oct 21, 2024
@chalin chalin requested a review from a team as a code owner October 21, 2024 15:09
@opentelemetrybot opentelemetrybot requested review from a team October 21, 2024 15:09
@chalin
Copy link
Contributor Author

chalin commented Oct 21, 2024

@jack-berg ☝️ ... what do you think of the newly recommended process for handling link-check failures in non-English pages?

@chalin chalin changed the title [i18n, CI] Document how to deal with non-en broken links [i18n, CI] How to deal with broken links in non-en pages when updating en pages Oct 21, 2024
@jack-berg
Copy link
Member

Works for me @chalin!

@chalin
Copy link
Contributor Author

chalin commented Oct 21, 2024

Thanks all for your feedback!

@open-telemetry/docs-ja-approvers - take note of the ja-page changes in this PR, and please work towards updating your pages, resolving the link-checking issues, and removing the IgnoreDirs entry in your ja page.

@open-telemetry/docs-pt-approvers - take note of the pt-page changes in this PR, and please work towards updating your pages, resolving the link-checking issues, and removing the IgnoreDirs entry in your pt page.

@chalin chalin merged commit 0457368 into open-telemetry:main Oct 21, 2024
17 checks passed
@chalin chalin deleted the chalin-im-htmltest-config-2024-10-21 branch October 21, 2024 15:35
olamideTiana pushed a commit to olamideTiana/opentelemetry.io that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blog CI/infra CI & infrastructure i18n internationalization lang:ja lang:pt
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants