PR for "Rework Building a Connector images" #5407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: svrnm <[email protected]>
opentelemetrybot
requested review from
a team and
evan-bradley
and removed request for
a team
svrnm
requested changes
Oct 15, 2024
content/en/docs/collector/deployment/otel-collector-before-connector.png
Outdated
Show resolved
Hide resolved
svrnm
reviewed
Oct 17, 2024
content/en/docs/collector/img/otel-collector-after-connector.svg.svg
Outdated
Show resolved
Hide resolved
svrnm
approved these changes
Oct 18, 2024
|
@open-telemetry/collector-approvers please take a look! |
|
@Beccamak while we wait for @open-telemetry/collector-approvers to take a look, you can treat this PR as "done" for your outreachy application. |
|
@svrnm Thank you so much. I'll update my contribution. |
|
@Beccamak I prepare your PR for being merge, I just did a mistake myself, will fix it and have it ready then, nothing for you to worry about |
Signed-off-by: svrnm <[email protected]>
|
@svrnm Wow!!! Thank you so much 🙏 I'm so sorry about the mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@svrnm I trust your day is going well, mentor. This is the PR for this issue #5358
I also made some changes to the SVG file based on your suggestion. Please look through it when you can.
Thank you so much for always taking the time to review things.
I'm looking forward to your feedback.