Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tags to registry entries #5382

Merged
merged 14 commits into from
Nov 11, 2024
Merged

add tags to registry entries #5382

merged 14 commits into from
Nov 11, 2024

Conversation

olamideTiana
Copy link
Contributor

#5336 [Outreachy] Registry: Add Tags to Items
@svrnm Please review the changes and let me know if there's anything to correct, i'll appreciate your feedback

@olamideTiana olamideTiana requested a review from a team as a code owner October 10, 2024 22:15
@olamideTiana olamideTiana changed the title Add Tags to Items #5336 Add Tags to entries #5336 Oct 10, 2024
@svrnm
Copy link
Member

svrnm commented Oct 11, 2024

@olamideTiana your PR still touches ~130 files in data/registry, can you revert those changes, this also fails the build of the website for preview

@olamideTiana
Copy link
Contributor Author

I've reverted changes made @svrnm

@olamideTiana
Copy link
Contributor Author

@svrnm Hello, I hope you're doing great, I'll appreciate getting your feedback on the changes I've made, Thanks

@olamideTiana olamideTiana changed the title Add Tags to entries #5336 [Outreachy] Add Tags to entries #5336 Oct 15, 2024
@olamideTiana
Copy link
Contributor Author

olamideTiana commented Oct 15, 2024 •
edited
Loading

@svrnm Sorry for the confusion, I think I opened two Pull Request but this is the Pull request I opened first, I saw your comment in the other Pull Request and I've resolved it. I've made the changes, I added the tags using Bootstrap.
So here's what I did, I had to modify the existing code to include a tag display then I created a new tags section to display the tags and each tags is styled using Bootstrap badge component. Please, Kindly look into it and apologies for any inconveniences. Thank you Sir

@olamideTiana
Copy link
Contributor Author

@svrnm Please, can I get the outreachy label here? Thanks

@svrnm svrnm added the outreachy Issues for Outreachy Participants label Oct 15, 2024
svrnm
svrnm requested changes Oct 15, 2024
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks! A few comments.

layouts/partials/ecosystem/registry/entry.html Outdated Show resolved Hide resolved
layouts/partials/ecosystem/registry/entry.html Outdated Show resolved Hide resolved
layouts/partials/ecosystem/registry/entry.html Outdated Show resolved Hide resolved
layouts/partials/ecosystem/registry/entry.html Outdated Show resolved Hide resolved
@svrnm svrnm changed the title [Outreachy] Add Tags to entries #5336 ✅ [Outreachy] Add Tags to entries #5336 Oct 21, 2024
@svrnm
Copy link
Member

svrnm commented Oct 21, 2024

Thank you @olamideTiana ! This looks really good, I consider this as done! After the outreachy application phase we will take another look and see if we can merge this PR.

@olamideTiana
Copy link
Contributor Author

@svrnm Thank you sir. I really appreciate your kind review

@opentelemetrybot opentelemetrybot requested review from a team October 21, 2024 22:46
@svrnm svrnm changed the title ✅ [Outreachy] Add Tags to entries #5336 add tags to registry entries Nov 11, 2024
@svrnm svrnm added ux and removed sig:demo outreachy Issues for Outreachy Participants labels Nov 11, 2024
@svrnm svrnm removed the request for review from a team November 11, 2024 14:39
@svrnm svrnm added this pull request to the merge queue Nov 11, 2024
Merged via the queue into open-telemetry:main with commit b58496a Nov 11, 2024
17 checks passed
drewby pushed a commit to drewby/opentelemetry.io that referenced this pull request Nov 21, 2024
@olamideTiana @svrnm @drewby
add tags to registry entries (open-telemetry#5382)
b176b96 
Signed-off-by: svrnm <[email protected]>
Co-authored-by: Severin Neumann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svrnm svrnm svrnm approved these changes

Assignees
No one assigned
Labels
registry ux
Projects
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olamideTiana @svrnm