-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Outreachy] Registry: Add Tags to Items #5336 #5373
Conversation
@svrnm Please Kindly review sir and I'll appreciate your feedback on it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add Tags to Items
tags: | ||
tags: Metrics | ||
- collector | ||
- cloud foundry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"collector" and "cloud foundry" are the tags already, you don't need to add anything to those files.
@olamideTiana a few hints for you what needs to be done: In the file https://github.com/open-telemetry/opentelemetry.io/blob/main/layouts/partials/ecosystem/registry/entry.html you will need to find a place where to put the tags. To begin with there is no need to read the data from the entry yet, just use some sample values to setup the user experience for it. You can take inspiration from other registries how they display tags, e.g. https://www.npmjs.com/search?q=opentelemetry |
Ohh, sorry for the inconvenience @svrnm Thanks for shedding more light to the issue, I'll fix it now. By the way, can I close this PR |
If you want to start from scratch, yes, close this PR and raise a new one, no problem with that |
@svrnm Okay, thank you |
#5336 - Add Tags to Items
Added Tags to the existing data entries