-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor java instrumentation #5276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jack-berg - please rebase and resolve conflicts before we proceed:
I've merged |
Yes rebase from a freshly updated upstream |
This is the kind of wonkiness that can happen. Please rebase from a freshly updated upstream |
769aae6
to
fe3100a
Compare
That did the trick. Thanks! |
31f6f96
to
1a458de
Compare
From the GH checks:
This needs to be fixed, FYI. Because all As for non-en pages, a general strategy (I'm proposing) is it create a temporary link-checker ignore rule for the problematic pages, along with an issue to track its removal. I'll do that too so illustrate how that look for this PR. |
1878a1d
to
80b69a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All GH checks are passing now. I don't have time to further review the PR, so I'll lean on @svrnm et all for the rest. Thanks for pushing this forward @jack-berg! I'll mark as approved for the checking & layouts aspects.
Thanks for all your help @chalin! |
I love it! ❤️ |
🎉 |
Co-authored-by: Patrice Chalin <[email protected]>
Related to open-telemetry/opentelemetry-go#5211. Followup to open-telemetry/opentelemetry-go#4966.
This PR breaks up and adds coherence to the topics currently discussed in Instrumentation:
The PR for the code snippet additions to
opentelemetry-java-examples
is available here: open-telemetry/opentelemetry-java-examples#498There is a lot of content in this PR, but like open-telemetry/opentelemetry-go#4966, the principles are simple and scalable. I recommend reviewing by looking at the rendered website. Links to previews for main pages involved:
cc @open-telemetry/java-approvers, @open-telemetry/java-instrumentation-approvers
Redirect test: