-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contributing: improved guidance for quick-fixers, mentees, and more #5266
Merged
theletterf
merged 6 commits into
open-telemetry:main
from
chalin:chalin-contributing-2024-09-28
Sep 30, 2024
Merged
Contributing: improved guidance for quick-fixers, mentees, and more #5266
theletterf
merged 6 commits into
open-telemetry:main
from
chalin:chalin-contributing-2024-09-28
Sep 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chalin
commented
Sep 28, 2024
•
edited
Loading
edited
- "Contributing" landing page - call out / cater to:
- "quick-fixers" (for typos)
- first-timers (read "mentees"), and
- the rest of the contributors
- Recovers the first-timers' instructions that didn't make the restructuring of the `CONTRIBUTING.md1 page (from here https://github.com/open-telemetry/opentelemetry.io/pull/4654/files#diff-eca12c0a30e25b4b46522ebf89465a03ba72a03f540796c979137931d8f92055L50), which emphasized that:
- Look for "good first issue" issues
- We don't cater to "please assign to me" comments
- Some page and title rename & rework
theletterf
approved these changes
Sep 28, 2024
chalin
commented
Sep 28, 2024
Comment on lines
+11
to
+12
# TODO drop after https://github.com/open-telemetry/opentelemetry.io/issues/5267 is fixed: | ||
- zh/docs/contributing/pr-checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@open-telemetry/docs-zh-approvers - this temporary ignore rule will need to be removed as a part of the fix to
chalin
changed the title
[WIP] Contributing: improved guidance for quick-fixers, mentees, and more
Contributing: improved guidance for quick-fixers, mentees, and more
Sep 28, 2024
TineoC
pushed a commit
to TineoC/opentelemetry.io
that referenced
this pull request
Sep 30, 2024
TineoC
pushed a commit
to TineoC/opentelemetry.io
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.