Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[collector] Update internal metrics config examples, suggest OTLP for pushing metrics #5212

Merged
merged 1 commit into from
Sep 17, 2024
Merged

[collector] Update internal metrics config examples, suggest OTLP for pushing metrics #5212

merged 1 commit into from
Sep 17, 2024

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu requested a review from a team September 17, 2024 19:44
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Sep 17, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: bogdandrutu / name: Bogdan Drutu (761534f)

@opentelemetrybot opentelemetrybot requested review from a team and atoulme and removed request for a team September 17, 2024 19:44
@bogdandrutu bogdandrutu force-pushed the update-internal-metrics branch from 15d3710 to 6c35006 Compare September 17, 2024 19:45
@opentelemetrybot opentelemetrybot requested a review from a team September 17, 2024 19:45
@bogdandrutu bogdandrutu force-pushed the update-internal-metrics branch from 6c35006 to 3cda11e Compare September 17, 2024 19:48
@opentelemetrybot opentelemetrybot requested a review from a team September 17, 2024 19:48
codeboten
codeboten approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend changing the OTLP port to 14317 (so as not to confuse the prometheus port) in the example

content/en/docs/collector/internal-telemetry.md Outdated Show resolved Hide resolved
content/en/docs/collector/internal-telemetry.md Outdated Show resolved Hide resolved
content/en/docs/collector/internal-telemetry.md Outdated Show resolved Hide resolved
content/en/docs/collector/internal-telemetry.md Outdated Show resolved Hide resolved
@bogdandrutu bogdandrutu force-pushed the update-internal-metrics branch from 3cda11e to f5f0211 Compare September 17, 2024 20:02
@opentelemetrybot opentelemetrybot requested a review from a team September 17, 2024 20:02
@bogdandrutu bogdandrutu force-pushed the update-internal-metrics branch 3 times, most recently from c924553 to 2aa1895 Compare September 17, 2024 20:15
@bogdandrutu bogdandrutu force-pushed the update-internal-metrics branch from 2aa1895 to 761534f Compare September 17, 2024 20:41
@cartermp cartermp added this pull request to the merge queue Sep 17, 2024
Merged via the queue into open-telemetry:main with commit 7934afd Sep 17, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-mcreech sfc-gh-mcreech sfc-gh-mcreech left review comments

@tiffany76 tiffany76 tiffany76 approved these changes

@cartermp cartermp cartermp approved these changes

@djaglowski djaglowski djaglowski approved these changes

@codeboten codeboten codeboten approved these changes

@tedsuo tedsuo tedsuo approved these changes

@atoulme atoulme Awaiting requested review from atoulme

Assignees
No one assigned
Labels
sig:collector
Projects
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bogdandrutu @tedsuo @codeboten @djaglowski @cartermp @tiffany76 @sfc-gh-mcreech