Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ux] Rework OTel-highlights ribbon, move Integrations to ribbon #5156

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Sep 6, 2024

Contributes to:

For motivation, see that issue's description. IMHO, there is more work to be done, but this is a low hanging fruit, which eliminates the Integrations CTA

This PR reworks the OTel-highlights "ribbon", in particular makes these changes for the three ribbon entries (for screenshots, see below):

  • Telemetry ribbon entry (the first one): adds a "read more" link to the OTel primer
  • Second ribbon entry changed to link to the Integrations page. Adds a link to the Instrumentation page
  • Third entry: adds link to Adopters page

Ribbon screenshots

Before:

image

After:

image

CTA screenshots

Before:

image

After:

image

@chalin chalin requested a review from a team September 6, 2024 10:38
@theletterf
Copy link
Member

Love it. I'd narrow it further down to these:

Screenshot 2024-09-06 at 15 39 58

Notice that I'd remove the link in "get started", too.

@chalin
Copy link
Contributor Author

chalin commented Sep 6, 2024

Thank you for the feedback @theletterf. I'd like to propose that we approach the CTA / Getting-started related design issues incrementally, and so keep this PR focused on the rework related to integrations.

I agree that there's more that can be done, both respect to demo and getting-started CTAs, but I might want to have a brief discussion about alternatives before we do that. I've added a few thoughts starting at #5155 (comment).

If you are ok with the changes proposed here, how about we get this approved and merged as a first step?

@theletterf
Copy link
Member

Totally. Let's sculpt this progressively.

Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I left a couple small suggestions.

content/en/_index.md Outdated Show resolved Hide resolved
content/en/_index.md Outdated Show resolved Hide resolved
{{% blocks/feature icon="fas fa-magic" title="Drop-In Instrumentation"%}}
{{% /blocks/feature %}}

{{% blocks/feature icon="fas fa-magic" title="Drop-in Instrumentation & Integrations" %}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we remove the "Drop-in", can we get the heading all on one line? If so, I think it's worth removing to balance the three blocks.

Copy link
Contributor Author

@chalin chalin Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I understood from the original intent (cc @austinlparker @tedsuo) was that the use of "drop-in" was purposeful here, and part of the "marketing" tag line :).

Any thoughts from others about this? @theletterf @svrnm @cartermp

chalin and others added 2 commits September 6, 2024 14:42
Co-authored-by: Tiffany Hrabusa <[email protected]>
Co-authored-by: Tiffany Hrabusa <[email protected]>
@chalin
Copy link
Contributor Author

chalin commented Sep 6, 2024

/fix:format

@opentelemetrybot
Copy link
Collaborator

@opentelemetrybot
Copy link
Collaborator

fix:format was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@chalin
Copy link
Contributor Author

chalin commented Sep 8, 2024

I'm going to merge this now, esp. given that there's more work to be done in the context of #5155. We can always address the potential shortening of the ribbon entry title then

@chalin chalin added this pull request to the merge queue Sep 8, 2024
Merged via the queue into open-telemetry:main with commit 90dcedd Sep 8, 2024
5 checks passed
@chalin chalin deleted the chalin-im-integrations-2024-09-06 branch September 8, 2024 01:10
michael2893 pushed a commit to michael2893/opentelemetry.io that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants