-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ux] Rework OTel-highlights ribbon, move Integrations to ribbon #5156
[ux] Rework OTel-highlights ribbon, move Integrations to ribbon #5156
Conversation
Thank you for the feedback @theletterf. I'd like to propose that we approach the CTA / Getting-started related design issues incrementally, and so keep this PR focused on the rework related to integrations. I agree that there's more that can be done, both respect to demo and getting-started CTAs, but I might want to have a brief discussion about alternatives before we do that. I've added a few thoughts starting at #5155 (comment). If you are ok with the changes proposed here, how about we get this approved and merged as a first step? |
Totally. Let's sculpt this progressively. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I left a couple small suggestions.
{{% blocks/feature icon="fas fa-magic" title="Drop-In Instrumentation"%}} | ||
{{% /blocks/feature %}} | ||
|
||
{{% blocks/feature icon="fas fa-magic" title="Drop-in Instrumentation & Integrations" %}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we remove the "Drop-in", can we get the heading all on one line? If so, I think it's worth removing to balance the three blocks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I understood from the original intent (cc @austinlparker @tedsuo) was that the use of "drop-in" was purposeful here, and part of the "marketing" tag line :).
Any thoughts from others about this? @theletterf @svrnm @cartermp
Co-authored-by: Tiffany Hrabusa <[email protected]>
Co-authored-by: Tiffany Hrabusa <[email protected]>
/fix:format |
You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/10743666996 |
IMPORTANT: (RE-)RUN
|
I'm going to merge this now, esp. given that there's more work to be done in the context of #5155. We can always address the potential shortening of the ribbon entry title then |
…-telemetry#5156) Co-authored-by: Tiffany Hrabusa <[email protected]> Co-authored-by: opentelemetrybot <[email protected]>
Contributes to:
For motivation, see that issue's description. IMHO, there is more work to be done, but this is a low hanging fruit, which eliminates the Integrations CTA
This PR reworks the OTel-highlights "ribbon", in particular makes these changes for the three ribbon entries (for screenshots, see below):
Ribbon screenshots
Before:
After:
CTA screenshots
Before:
After: