-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): Update getting started to not use Bandit as it is not re… #5142
chore(docs): Update getting started to not use Bandit as it is not re… #5142
Conversation
242b1b8
to
e8b3a0a
Compare
e8b3a0a
to
c8e5a76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change.
Also, could you confirm the reference to "the last three" in Line 81 is still accurate?
Co-authored-by: Tiffany Hrabusa <[email protected]>
@tiffany76 thanks for helping! The linter seems to be super helpful, neat! When I added this a couple months ago, seems like it was 2 only (line 75 below). But it seems like it got introduced here, so I'll likely defer to folks that know more about this? Thanks again for helping. |
@tiffany76, it's only two things being set up, I'm pretty sure two is the correct. Pushed an update for that. I'm not sure if you all squash commits automatically or not, if not, just please let me know and I'll do it. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @pdgonzalez872! The commits will be squashed when the maintainers merge into main.
Thank you @pdgonzalez872 ! |
open-telemetry#5142) Co-authored-by: Tiffany Hrabusa <[email protected]>
…ady. Reverts #4518, per #4518 (comment)