Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Update getting started to not use Bandit as it is not re… #5142

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

pdgonzalez872
Copy link
Contributor

…ady. Reverts #4518, per #4518 (comment)

@pdgonzalez872 pdgonzalez872 requested a review from a team September 3, 2024 18:32
@opentelemetrybot opentelemetrybot requested a review from a team September 3, 2024 18:33
@opentelemetrybot opentelemetrybot requested a review from a team September 3, 2024 18:44
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change.

Also, could you confirm the reference to "the last three" in Line 81 is still accurate?

content/en/docs/languages/erlang/getting-started.md Outdated Show resolved Hide resolved
@pdgonzalez872
Copy link
Contributor Author

@tiffany76 thanks for helping! The linter seems to be super helpful, neat!

When I added this a couple months ago, seems like it was 2 only (line 75 below).
image

But it seems like it got introduced here, so I'll likely defer to folks that know more about this?

Thanks again for helping.

@pdgonzalez872
Copy link
Contributor Author

@tiffany76, it's only two things being set up, I'm pretty sure two is the correct. Pushed an update for that.

I'm not sure if you all squash commits automatically or not, if not, just please let me know and I'll do it.

Thanks!

Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @pdgonzalez872! The commits will be squashed when the maintainers merge into main.

@theletterf theletterf added this pull request to the merge queue Sep 4, 2024
Merged via the queue into open-telemetry:main with commit e36a005 Sep 4, 2024
17 checks passed
@bryannaegele
Copy link

Thank you @pdgonzalez872 !

@pdgonzalez872 pdgonzalez872 deleted the pg-manual-revert-01 branch September 4, 2024 15:07
michael2893 pushed a commit to michael2893/opentelemetry.io that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants