correct metric type for http req/res sizes #5141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opentelemetrybot
requested review from
a team and
bogdandrutu
and removed request for
a team
theletterf
approved these changes
Sep 3, 2024
jpkrohling
approved these changes
Sep 3, 2024
|
Thankyou @jpkrohling! |
|
For what it's worth, a counter here is more useful for me because I want to know total bytes rather than distribution over requests. I can see use cases for both. This is probably not the right place to discuss it, though. |
michael2893
pushed a commit
to michael2893/opentelemetry.io
that referenced
this pull request
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me a while to find out these docs were wrong, reading the OTLP receiver code, then the obs reporter helper, then the opentelemetry-go-contrib which holds the instrumentation for the HTTP servers. Thought I would save someone else the time.
These are counters, not histogram. Here is the code that records this: link
Interestingly, the gRPC code uses a histogram, so I've left it: link