Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add last9 to otel vendors.yaml #5121

Merged
merged 3 commits into from
Aug 31, 2024
Merged

add last9 to otel vendors.yaml #5121

merged 3 commits into from
Aug 31, 2024

Conversation

sahilk
Copy link
Contributor

@sahilk sahilk commented Aug 29, 2024

@sahilk sahilk requested a review from a team August 29, 2024 14:53
Copy link

linux-foundation-easycla bot commented Aug 29, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: cartermp / name: Phillip Carter (63e304b)
  • ✅ login: opentelemetrybot / name: OpenTelemetry Bot (ff28ded)
  • ✅ login: sahilk / name: Sahil Khan (f9d38f0)

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to sign the CLA @sahilk.

@sahilk
Copy link
Contributor Author

sahilk commented Aug 29, 2024

@chalin Done.

@chalin
Copy link
Contributor

chalin commented Aug 29, 2024

/fix:all

@opentelemetrybot
Copy link
Collaborator

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.\n### NOW RUN to ensure that there are no other check issues.

@chalin
Copy link
Contributor

chalin commented Aug 30, 2024

/fix:format

@opentelemetrybot
Copy link
Collaborator

@opentelemetrybot
Copy link
Collaborator

fix:format was successful.\n### NOW (RE-)RUN /fix:all to ensure that there are no other check issues.

@chalin
Copy link
Contributor

chalin commented Aug 30, 2024

/fix:format

@opentelemetrybot
Copy link
Collaborator

@opentelemetrybot
Copy link
Collaborator

fix:format was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@chalin
Copy link
Contributor

chalin commented Aug 30, 2024

@sahilk - apologies for the comment "noise", I've been testing workflow updates.
I'll let other @open-telemetry/docs-approvers do a final approval and merge.

@sahilk
Copy link
Contributor Author

sahilk commented Aug 30, 2024

@chalin No sweat at all! 😅🙏

@sahilk
Copy link
Contributor Author

sahilk commented Aug 31, 2024

@chalin Sorry, but could you check who can merge this? Don't see anyone tagged above so unsure about this. Thanks!

@cartermp cartermp added this pull request to the merge queue Aug 31, 2024
Merged via the queue into open-telemetry:main with commit a1740fd Aug 31, 2024
17 checks passed
@sahilk sahilk deleted the patch-2 branch August 31, 2024 18:15
michael2893 pushed a commit to michael2893/opentelemetry.io that referenced this pull request Sep 8, 2024
Co-authored-by: opentelemetrybot <[email protected]>
Co-authored-by: Phillip Carter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants