Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh] add blog docs-localized.md #5112

Merged
merged 4 commits into from
Aug 28, 2024
Merged

[zh] add blog docs-localized.md #5112

merged 4 commits into from
Aug 28, 2024

Conversation

shalk
Copy link
Contributor

@shalk shalk commented Aug 27, 2024

No description provided.

@shalk shalk requested a review from a team August 27, 2024 12:52
@opentelemetrybot opentelemetrybot requested review from a team August 27, 2024 12:52
@shalk shalk changed the title zh: add blog docs-localized.md [zh] add blog docs-localized.md Aug 27, 2024
reyang
reyang approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some non-blocking suggestions.

@opentelemetrybot opentelemetrybot requested a review from a team August 28, 2024 03:46
windsonsea
windsonsea reviewed Aug 28, 2024
View reviewed changes
Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrap long lines to provide convenience for later update.

content/zh/blogs/2024/docs-localized.md Outdated Show resolved Hide resolved
content/zh/blogs/2024/docs-localized.md Outdated Show resolved Hide resolved
content/zh/blogs/2024/docs-localized.md Outdated Show resolved Hide resolved
content/zh/blogs/2024/docs-localized.md Outdated Show resolved Hide resolved
@opentelemetrybot opentelemetrybot requested a review from a team August 28, 2024 05:55
windsonsea
windsonsea approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm.

@theletterf theletterf added this pull request to the merge queue Aug 28, 2024
Merged via the queue into open-telemetry:main with commit 8463974 Aug 28, 2024
17 checks passed
michael2893 pushed a commit to michael2893/opentelemetry.io that referenced this pull request Sep 8, 2024
@shalk @reyang @windsonsea
[zh] add blog docs-localized.md (open-telemetry#5112)
1a83914 
Co-authored-by: Reiley Yang <[email protected]>
Co-authored-by: Michael <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@my-git9 my-git9 my-git9 left review comments

@windsonsea windsonsea windsonsea approved these changes

@reyang reyang reyang approved these changes

Assignees
No one assigned
Labels
lang:zh
Projects
SIG Comms: Docs Translation
Status: Done
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shalk @reyang @my-git9 @windsonsea @theletterf