Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] add Japanese translation of "install the collector" #5109

Closed

Conversation

ymotongpoo
Copy link
Contributor

Translate this page into Japanese: https://opentelemetry.io/docs/collector/installation/

@ymotongpoo ymotongpoo requested a review from a team August 27, 2024 00:45
@opentelemetrybot opentelemetrybot requested review from a team August 27, 2024 00:45
@theletterf
Copy link
Member

@open-telemetry/docs-ja-approvers Please have a look.

@@ -0,0 +1,296 @@
---
title: コレクターのインストール
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原文が "Install the Collector" で、大文字始まりのCollectorなので、英語表記のまま「Collectorのインストール」にしたい。
以下の文章中も、大文字始まりCollectorの箇所は英語表記のままにしたい。


## Kubernetes

次のコマンドは、エージェントをデーモンセットと単一のゲートウェイインスタンスとしてデプロイします。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

「デーモンセットとしてエージェントと、単一のゲートウェイインスタンスをデプロイします」

@theletterf
Copy link
Member

@ymotongpoo Could you check the suggestions? Thanks!

@svrnm
Copy link
Member

svrnm commented Nov 5, 2024

@ymotongpoo any updates?

@ymotongpoo ymotongpoo force-pushed the ja/collector/install branch from 6b8702a to ed822b9 Compare November 6, 2024 15:02
@ymotongpoo ymotongpoo requested a review from a team as a code owner November 6, 2024 15:02
Copy link

CLA Missing ID CLA Not Signed

@opentelemetrybot opentelemetrybot requested review from a team November 6, 2024 15:02
@ymotongpoo
Copy link
Contributor Author

@svrnm @theletterf sorry for the delay. I've been in the process of changing jobs and have had no time for this. I'm trying to make time.

@ymotongpoo
Copy link
Contributor Author

It turned out that I need to recreate the PR with new company email address so that EasyCLA process properly understand the requester.

@svrnm
Copy link
Member

svrnm commented Nov 7, 2024

@svrnm @theletterf sorry for the delay. I've been in the process of changing jobs and have had no time for this. I'm trying to make time.

No worries, we check in from time to time with PRs pending, but we all understand that live changes and priorties shift. Glad to hear that you found a new place to work for and still want to find time to work on this.

It turned out that I need to recreate the PR with new company email address so that EasyCLA process properly understand the requester.

Yes, that might be a thing, if you need to close this PR and raise a new one don't hesitate to do that

@ymotongpoo
Copy link
Contributor Author

Thank you, @svrnm for checking in and suggestion! Closing this PR for now and I'll reopen with new email address marked.

@ymotongpoo ymotongpoo closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants