Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pt] Add content/pt/docs/concepts/instrumentation/code-based.md #5093

Merged
merged 31 commits into from
Aug 26, 2024
Merged

[pt] Add content/pt/docs/concepts/instrumentation/code-based.md #5093

merged 31 commits into from
Aug 26, 2024

Conversation

janssenlima
Copy link
Contributor

Add localization instrumentation code-based.

Issue: #4922

@janssenlima janssenlima requested a review from a team August 22, 2024 23:19
@opentelemetrybot opentelemetrybot requested review from a team August 22, 2024 23:19
@opentelemetrybot opentelemetrybot requested a review from a team August 23, 2024 11:28
emdneto
emdneto approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@emdneto
Copy link
Member

emdneto commented Aug 23, 2024

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/10526877854

@opentelemetrybot opentelemetrybot requested a review from a team August 23, 2024 15:17
lgfa29
lgfa29 reviewed Aug 23, 2024
View reviewed changes
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ótimo trabalho @janssenlima!

Deixei algumas ideias e sugestões 🙂

content/pt/docs/concepts/instrumentation/code-based.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/instrumentation/code-based.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/instrumentation/code-based.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/instrumentation/code-based.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/instrumentation/code-based.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/instrumentation/code-based.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/instrumentation/code-based.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/instrumentation/code-based.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/instrumentation/code-based.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/instrumentation/code-based.md Outdated Show resolved Hide resolved
@chalin
Copy link
Contributor

chalin commented Aug 23, 2024

@emdneto et al.: is this ready to be merged (and have any remaining comments addressed in a followup PR)?

@edsoncelio edsoncelio mentioned this pull request Aug 23, 2024
Closed
26 tasks
@emdneto
Copy link
Member

emdneto commented Aug 23, 2024 •
edited
Loading

@chalin I will move this PR to draft while @janssenlima addresses the suggestions. There are important fixes that we missed at the first look

@emdneto emdneto marked this pull request as draft August 23, 2024 17:37
@janssenlima janssenlima marked this pull request as ready for review August 23, 2024 19:59
@janssenlima janssenlima marked this pull request as draft August 23, 2024 23:44
@janssenlima
Copy link
Contributor Author

@chalin I will move this PR to draft while @janssenlima addresses the suggestions. There are important fixes that we missed at the first look

@emdneto, fiz os ajustes. Só tem uma thread ali em discussão para fechar a documentação.

@janssenlima
Update code-based.md
ab04256 
Title changed according to alignment.
@janssenlima janssenlima marked this pull request as ready for review August 26, 2024 02:01
@janssenlima
Copy link
Contributor Author

@emdneto, fiz todas as correções.

@emdneto
Copy link
Member

emdneto commented Aug 26, 2024

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/10558843861

@opentelemetrybot
Copy link
Collaborator

fix:all run failed, please check https://github.com/open-telemetry/opentelemetry.io/actions/runs/10558843861 for details

@theletterf theletterf added this pull request to the merge queue Aug 26, 2024
Merged via the queue into open-telemetry:main with commit 5459f7e Aug 26, 2024
17 checks passed
@janssenlima janssenlima deleted the pt-br_code-based branch August 31, 2024 19:07
@edsoncelio edsoncelio mentioned this pull request Sep 6, 2024
Closed
michael2893 pushed a commit to michael2893/opentelemetry.io that referenced this pull request Sep 8, 2024
@janssenlima @emdneto
@EzzioMoreira @opentelemetrybot @chalin @lgfa29
[pt] Add content/pt/docs/concepts/instrumentation/code-based.md (open…
f983cdf 
…-telemetry#5093)

Co-authored-by: Emídio Neto <[email protected]>
Co-authored-by: Ezzio Moreira <[email protected]>
Co-authored-by: opentelemetrybot <[email protected]>
Co-authored-by: Patrice Chalin <[email protected]>
Co-authored-by: Luiz Aoqui <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EzzioMoreira EzzioMoreira EzzioMoreira left review comments

@marcelobaptista marcelobaptista marcelobaptista left review comments

@edsoncelio edsoncelio edsoncelio left review comments

@lgfa29 lgfa29 lgfa29 left review comments

@emdneto emdneto emdneto approved these changes

@theletterf theletterf theletterf approved these changes

Assignees
No one assigned
Labels
lang:pt
Projects
SIG Comms: Docs Translation
Status: Done
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@janssenlima @emdneto @opentelemetrybot @chalin @lgfa29 @theletterf @edsoncelio @marcelobaptista @EzzioMoreira