Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Checkmk App Integration Into the Registry #5079

Merged
merged 5 commits into from
Aug 27, 2024

Conversation

LiraLemur
Copy link
Contributor

This PR adds a Checkmk App Integration into the registry.

Description of the project: https://checkmk.com/werk/16565

@LiraLemur LiraLemur requested a review from a team August 21, 2024 13:02
Copy link

linux-foundation-easycla bot commented Aug 21, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@cartermp
Copy link
Contributor

@LiraLemur could you sign the CLA please? Thanks!

@LiraLemur
Copy link
Contributor Author

LiraLemur commented Aug 22, 2024

Hi @cartermp ! In the process of getting it signed by my colleague :)

@LiraLemur
Copy link
Contributor Author

@cartermp the CLA is ready 👍

@tiffany76 tiffany76 removed the CLA: no label Aug 22, 2024
@cartermp
Copy link
Contributor

/fix:all

@opentelemetrybot
Copy link
Collaborator

@opentelemetrybot
Copy link
Collaborator

fix:all run failed, please check https://github.com/open-telemetry/opentelemetry.io/actions/runs/10549467704 for details

@cartermp
Copy link
Contributor

/fix:refcache

@opentelemetrybot
Copy link
Collaborator

You triggered fix:refcache action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/10549520959

@LiraLemur
Copy link
Contributor Author

Hi @cartermp ! I am not sure if I can fix something here, as it seems that it is not the file I changed that does something to the checks.

Please let me know if I can/ should do something to fix this 👀

npm run test-and-fix suggested in the details of the check locally did not help due to some issues finding hugo modules (if I understood it correctly).

@opentelemetrybot
Copy link
Collaborator

fix:refcache run failed, please check https://github.com/open-telemetry/opentelemetry.io/actions/runs/10549520959 for details

@cartermp
Copy link
Contributor

@LiraLemur heh, sorry if not clear, the comments there are slash commands to kick off a CI process. Unfortunately the CI process doesn't appear to be working. Running npm run test-and-fix should have worked, but it there's hugo issues then that's something else. Maybe @chalin knows more?

@LiraLemur
Copy link
Contributor Author

LiraLemur commented Aug 26, 2024

I'm not sure that's a Hugo issue per se, as I probably do not have the correct environment locally for it to work. But it definitely seems like I'm digging in the wrong direction, so any hint would be appreciated, thank you!

@chalin
Copy link
Contributor

chalin commented Aug 26, 2024

As pointed out by @svrnm out-of-band, @LiraLemur you need to add a website URL to your entry.

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GH actions are green now. I'll let @cartermp or al. give a final approval and merge.

@LiraLemur
Copy link
Contributor Author

@chalin thank you so much again! 😊

@theletterf theletterf added this pull request to the merge queue Aug 27, 2024
Merged via the queue into open-telemetry:main with commit 68702f6 Aug 27, 2024
18 checks passed
michael2893 pushed a commit to michael2893/opentelemetry.io that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants