Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link to PrometheusHttpServer in prometheus-setup.md #5038

Merged
merged 6 commits into from
Aug 14, 2024
Merged

Update link to PrometheusHttpServer in prometheus-setup.md #5038

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0a820a0
Update prometheus-setup.md
theletterf Aug 14, 2024
2095fb5
Results from /fix:refcache
opentelemetrybot Aug 14, 2024
269ce17
Merge branch 'main' into theletterf-patch-1
theletterf Aug 14, 2024
8e4ec8c
Update prometheus-setup.md
theletterf Aug 14, 2024
a47931c
Merge branch 'main' into theletterf-patch-1
theletterf Aug 14, 2024
e91c000
Results from /fix:format
opentelemetrybot Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion layouts/shortcodes/docs/languages/exporters/prometheus-setup.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
To send your metric data to [Prometheus](https://prometheus.io/), you can either
[enable Prometheus' OTLP Receiver](https://prometheus.io/docs/prometheus/latest/feature_flags/#otlp-receiver)
and use the [OTLP exporter](#otlp) or you can use the
[`PrometheusHttpServer`](https://javadoc.io/doc/io.opentelemetry/opentelemetry-exporter-prometheus/latest/io/opentelemetry/exporter/prometheus/PrometheusHttpServer.html),
[`PrometheusHttpServer`](https://open-telemetry.github.io/opentelemetry-js/classes/_opentelemetry_exporter_prometheus.PrometheusExporter.html),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in a shortcode, so it is applied all languages using that shortcode, meaning we need to inject the correct URL as a parameter to the short code

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That also crossed my mind... Hmmm. Should we remove the link entirely?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not even the name is consistent across languages, so yes, maybe "Prometheus Exporter" without link and without the code-style

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited in 8e4ec8c, have a look!

a `MetricReader`, that starts an HTTP server that will collect metrics and
serialize to Prometheus text format on request.

Expand Down
4 changes: 4 additions & 0 deletions static/refcache.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6675,6 +6675,10 @@
"StatusCode": 206,
"LastSeen": "2024-01-18T19:07:28.680974-05:00"
},
"https://open-telemetry.github.io/opentelemetry-js/classes/_opentelemetry_exporter_prometheus.PrometheusExporter.html": {
"StatusCode": 206,
"LastSeen": "2024-08-14T08:01:01.892463087Z"
},
"https://open-telemetry.github.io/opentelemetry-js/interfaces/_opentelemetry_api.Tracer.html#startActiveSpan": {
"StatusCode": 206,
"LastSeen": "2024-01-30T06:06:08.253674-05:00"
Expand Down