Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor java SDK and configuration #4966

Merged
merged 22 commits into from
Sep 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .cspell/en-words.txt
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ jaeger
jaegertracing
javaagent
javadoc
javadocs
jboss
jdbc
julia
Expand Down
2 changes: 1 addition & 1 deletion .htmltest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ IgnoreDirs:
- ^blog/(\d+/)?page/\d+
IgnoreInternalURLs: # list of paths
IgnoreURLs: # list of regexs of paths or URLs to be ignored
- ^(/..)?/docs/languages/\w+/(api|examples|registry)/$
- ^((/..)?/docs/languages/\w+|\.\.)/(api|examples|registry)/$
- ^(/..)?/docs/collector/registry/$
- ^(/..)?/docs/languages/net/(metrics-api|traces-api)/
- ^((/..)?/docs/migration/)?opencensus/$
Expand Down
1 change: 1 addition & 0 deletions .textlintrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ rules:
- '(?<![.-])java\b(?![.])'
- Java
- ['java[- ]?agent', Java agent]
- ['java ?doc(s)?', 'Javadoc$1']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svrnm @theletterf - what do you think about this rule?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it catch "Java documentation" as well? So, if I write "to learn more about this, read the "Java documentation". Otherwise I am fine, since Javadoc seems to be the official notation

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be an issue for sentences like "You will find more details on that in the Java documentation" meaning our internal java documentation. So we need to make sure that it does only capture "java doc(s)" with a word boundary (\b if I am not wrong?)

- [mac ?os, macOS]
- ['meta[- ]data', metadata]
- [nd-?json, NDJSON]
Expand Down
1 change: 1 addition & 0 deletions content/en/docs/languages/java/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ cascade:
vers:
instrumentation: 2.8.0
otel: 1.42.1
contrib: 1.38.0
semconv: 1.27.0
weight: 18
---
Expand Down
982 changes: 627 additions & 355 deletions content/en/docs/languages/java/configuration.md

Large diffs are not rendered by default.

Loading