Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] add Japanese translation of quick start of collector #4879

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

ymotongpoo
Copy link
Contributor

Add Japanese translation of Quick Start page

@ymotongpoo ymotongpoo self-assigned this Jul 25, 2024
@ymotongpoo
Copy link
Contributor Author

@svrnm @chalin can you figure out why component owner check fails with this PR?

@svrnm
Copy link
Member

svrnm commented Jul 25, 2024

@svrnm @chalin can you figure out why component owner check fails with this PR?

they fail for all PRs because we are lacking permissions, I am currently waiting for the TC to help us with fixing that.

@svrnm svrnm requested a review from a team July 25, 2024 09:52
@ymotongpoo ymotongpoo force-pushed the ja/collector/quick-start branch from 74e43c4 to 21bc7bb Compare July 26, 2024 01:50
@ymotongpoo ymotongpoo force-pushed the ja/collector/quick-start branch from f898c6f to 884825a Compare July 27, 2024 04:39
@chalin
Copy link
Contributor

chalin commented Jul 27, 2024

@open-telemetry/docs-ja-approvers - PTAL

@chalin
Copy link
Contributor

chalin commented Jul 27, 2024

@ymotongpoo - is this a DRAFT because of the GH check failure? If so, you can remove the draft status.

@ymotongpoo ymotongpoo marked this pull request as ready for review July 28, 2024 10:02
@ymotongpoo ymotongpoo requested a review from a team July 28, 2024 10:02
@chalin chalin requested a review from a team July 28, 2024 12:04
@chalin chalin requested a review from a team July 28, 2024 12:05
@svrnm
Copy link
Member

svrnm commented Aug 1, 2024

@open-telemetry/docs-ja-approvers please take a look, we can only merge the PR with a review from a native speaker

@chalin chalin force-pushed the ja/collector/quick-start branch from a4e3872 to c8c4cb6 Compare August 2, 2024 16:37
@opentelemetrybot opentelemetrybot requested a review from a team August 2, 2024 16:37
@svrnm
Copy link
Member

svrnm commented Aug 9, 2024

@open-telemetry/docs-ja-approvers please take a look

@ymotongpoo ymotongpoo force-pushed the ja/collector/quick-start branch from c8c4cb6 to 6803fc2 Compare August 13, 2024 00:35
@ymotongpoo
Copy link
Contributor Author

@chalin this change was failed due to the fail of spelling checker for pt page. Could you take a look at the spell checker action configuration?

@svrnm
Copy link
Member

svrnm commented Aug 13, 2024

@chalin this change was failed due to the fail of spelling checker for pt page. Could you take a look at the spell checker action configuration?

I have a PR in place to fix that. Nevertheless we would need someone to review the translation.

@ymotongpoo ymotongpoo force-pushed the ja/collector/quick-start branch from 6803fc2 to 4fd5996 Compare August 21, 2024 00:23
@opentelemetrybot opentelemetrybot requested a review from a team August 21, 2024 00:24
@ymotongpoo
Copy link
Contributor Author

@open-telemetry/docs-approvers Thank you @chalin and @svrnm for fixing the link check action. Now this PR is good to merge.

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalin chalin added this pull request to the merge queue Aug 22, 2024
Merged via the queue into open-telemetry:main with commit 124e5fe Aug 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants