Fix queue length documentation #4872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svrnm
requested review from
a team and
evan-bradley
and removed request for
a team
There was a problem hiding this comment.
Thanks @tommyzli. Could you also update the metric definitions under the "basic-level metrics" section?
tiffany76
approved these changes
Jul 25, 2024
evan-bradley
approved these changes
Jul 25, 2024
opentelemetrybot
requested review from
a team and
TylerHelmuth
and removed request for
a team
chalin
approved these changes
Jul 26, 2024
|
All checks are passing except for the known component-owners issue. I'd merge, but given that it's assigned to you @svrnm, I'll let you handle it. |
The assignment was the outcome of a semi-failed run of the component owners. But yeah going to merge this. |
|
thank you @tommyzli ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs refer to the collector's queue as a retry queue, when it's actually a sending queue