Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go] Add zap log bridge #4845

Merged
merged 3 commits into from
Jul 18, 2024
Merged

[Go] Add zap log bridge #4845

merged 3 commits into from
Jul 18, 2024

Conversation

pellared
Copy link
Member

@pellared pellared commented Jul 18, 2024 •
edited
Loading

Fixes open-telemetry/opentelemetry-go-contrib#5191

I think it would be better to reuse the OTel Registry, but it is currently impossible:

@pellared pellared mentioned this pull request Jul 18, 2024
Closed
@pellared pellared marked this pull request as ready for review July 18, 2024 08:56
@pellared pellared requested review from a team July 18, 2024 08:56
@pellared
Copy link
Member Author

CC @khushijain21

@svrnm svrnm merged commit 63b66db into main Jul 18, 2024
18 checks passed
@svrnm svrnm deleted the otelzap branch July 18, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theletterf theletterf theletterf approved these changes

@svrnm svrnm svrnm approved these changes

Assignees
No one assigned
Labels
sig:go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add zap log bridge
3 participants
@pellared @svrnm @theletterf