Add native/firstParty flag to collector exporters #4836
Conversation
data/registry/collector-builder.yml
Outdated
| @@ -14,6 +14,7 @@ urls: | |||
| repo: https://github.com/open-telemetry/opentelemetry-collector/tree/main/cmd/builder | |||
| docs: /docs/collector/custom-collector/ | |||
| createdAt: 2023-12-18 | |||
| isFirstParty: true | |||
There was a problem hiding this comment.
Apologies, I should have been more specific in the original issue. This flag is not relevant for collector components it refers to instrumentations that are "first party", i.e. provided by the same org that created a certain app or library.
We could consider to have them for receivers/exporters hosted outside the community repos by orgs that create such modules fur their solution but I don't know if this is what we want them to do va adopting otlp
There was a problem hiding this comment.
I was unsure about this change. Thanks for the explanation.
I've made the adjustment to your change request, rebased and adjusted the commit message a bit, then did a force push.
Thanks again!
There was a problem hiding this comment.
Just to clarify, Do you mean that all collector-exporters don't need this change? In other words, this PR should be abandoned?
There was a problem hiding this comment.
Hmmm, I mean, I'm ambivalent here TBH, but I don't see why it wouldn't also be flagged?
There was a problem hiding this comment.
Depends on how we want to use that flag. We had a thirdParty flag in the past that we removed because it created so much confusion. Right now the first party flag is used in the registry to say what I outlined above. I don't know if we water down the value of that if all otel first party components have that label as well
To address open-telemetry#4795, this is a series of PRs that add native or first party flags to registries that lack them. This batch touches and all collector-exporter-* registries. Signed-off-by: Alex Ji <[email protected]>
haidong
force-pushed
the
native-firstParty-flag-4-collector-exporter
branch
from
59fc3cd to
da0c3fb
Compare
|
Moving the discussion out from my outdated comment:
I don't think that we should add the isFirstParty flag to non-instrumentation entries of the registry, especially not for things build by the opentelemetry community. Otherwise 50%+ of our entries would have this flag (it is currently not showing up because We already highlight components by the opentelemetry community by distinguishing the "by The OpenTelemetry Authors" from other others by highlighting them. Again, @haidong, I appreciate the effort you put into creating this PR, and I apologies for the confusion that my comment in #4795 might have created, but I would like to not implement this. |
|
Agreed, let's keep this scoped to just instrumentations then. |
|
I've been busy with other stuff and didn't get a chance to attend to this until today. Thanks all for your input. I've created a new PR that touch files under data/registry. Please let me know your suggestions/comments there. |
To address #4795, this is a series of PRs that add native or first party flags to registries that lack them. This batch touches collector-builder and all collector-exporter-* registries.