Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add i18n guidance re. images & shortcodes + some rework #4790

Merged
merged 3 commits into from
Jul 4, 2024
Merged

Add i18n guidance re. images & shortcodes + some rework #4790

merged 3 commits into from
Jul 4, 2024

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jul 3, 2024 •
edited
Loading

@chalin chalin added the i18n internationalization label Jul 3, 2024
@chalin chalin requested review from a team July 3, 2024 17:38
@chalin chalin mentioned this pull request Jul 3, 2024
Open
41 tasks
tiffany76
tiffany76 approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I broke up some of the longer sentences and suggested a few punctuation changes. Otherwise, LGTM!

content/en/docs/contributing/localization.md Outdated Show resolved Hide resolved
content/en/docs/contributing/localization.md Outdated Show resolved Hide resolved
content/en/docs/contributing/localization.md Outdated Show resolved Hide resolved
content/en/docs/contributing/localization.md Outdated Show resolved Hide resolved
content/en/docs/contributing/localization.md Outdated Show resolved Hide resolved
@chalin chalin force-pushed the chalin-im-i18n-docs-upd-2024-07-03 branch from 0baf18a to b8802d8 Compare July 4, 2024 16:35
@chalin chalin merged commit a37e423 into open-telemetry:main Jul 4, 2024
16 checks passed
@chalin chalin deleted the chalin-im-i18n-docs-upd-2024-07-03 branch July 4, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiffany76 tiffany76 tiffany76 approved these changes

@svrnm svrnm svrnm approved these changes

Assignees
No one assigned
Labels
i18n internationalization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[i18n] Ensure section-local image paths fall back to default lang image
3 participants
@chalin @svrnm @tiffany76