Clarify OSS definition for vendors #4788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theletterf
approved these changes
Jul 3, 2024
chalin
reviewed
Jul 3, 2024
There was a problem hiding this comment.
Hmm, sorry @theletterf, but I prefer @cartermp's original.
That being said, I think that we can do even better by lifting up footnote 1, and folding it into the explanation. WDYT?
This came up in DMs regarding Grafana, who have both an open source product and a closed source cloud offering.
|
/fix:all |
|
You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/9781564043 |
|
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/9781605864 |
|
@chalin That's OK! I think the singular can be a bit confusing, but overall the concept is clear. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in DMs regarding Grafana, who have both an open source product and a closed source cloud offering.