Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable page-feedback form for doc pages #4772

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Enable page-feedback form for doc pages #4772

merged 2 commits into from
Jul 1, 2024

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jul 1, 2024 •
edited
Loading

@chalin chalin requested a review from a team July 1, 2024 21:58
tiffany76
tiffany76 approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested one small punctuation change.

Looks great! Thanks, @chalin!

hugo.yaml Outdated Show resolved Hide resolved
@chalin @tiffany76
Tiffany's feedback
5b78494 
Co-authored-by: Tiffany Hrabusa <[email protected]>
@chalin chalin mentioned this pull request Jul 1, 2024
Closed
2 tasks
@chalin
Copy link
Contributor Author

chalin commented Jul 1, 2024

I restarted the Netlify build, and the build runs fine now: https://app.netlify.com/sites/opentelemetry/deploys/66832c787ae60bb25b90968b. Merging.

@chalin chalin merged commit 802beb9 into open-telemetry:main Jul 1, 2024
12 of 16 checks passed
@chalin chalin deleted the chalin-im-page-feedback-2024-07-01 branch July 1, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiffany76 tiffany76 tiffany76 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chalin @tiffany76