[zh] add contributing/style-guide.md #4685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theletterf
reviewed
Jun 14, 2024
reyang
approved these changes
Jun 14, 2024
I just checked and can confirm that that style guide makes sense for Chinese. |
chalin
force-pushed
the
style-guide
branch
2 times, most recently
from
03f4cc0 to
5ffbc35
Compare
chalin
reviewed
Jun 14, 2024
There was a problem hiding this comment.
This page will need to be updated to conform to https://opentelemetry.io/docs/contributing/localization/#translation-tips, in particular header IDs are missing.
theletterf
approved these changes
Jun 20, 2024
Signed-off-by: Dariel Li <[email protected]>
chalin
approved these changes
Jul 24, 2024
|
Ignoring Component-owners GH action failure for now and merging, since all other checks are green: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[zh] add contributing/style-guide.md