Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update approver and maintainer practices #4684

Merged
merged 8 commits into from
Jun 14, 2024
Merged

Update approver and maintainer practices #4684

merged 8 commits into from
Jun 14, 2024

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Jun 14, 2024

No description provided.

@svrnm svrnm requested review from a team June 14, 2024 09:33
@svrnm
Copy link
Member Author

svrnm commented Jun 14, 2024

/fix:all

@opentelemetrybot
Copy link
Collaborator

@svrnm
Copy link
Member Author

svrnm commented Jun 14, 2024

/fix:all

@opentelemetrybot
Copy link
Collaborator

content/en/docs/contributing/development.md Outdated Show resolved Hide resolved
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. See inline comments.

content/en/docs/contributing/development.md Outdated Show resolved Hide resolved
content/en/docs/contributing/development.md Show resolved Hide resolved
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Thanks!

@theletterf
Copy link
Member

Warning: Unknown word (chalin)

😅 I'll fix that and merge.

@theletterf theletterf merged commit 508a3ed into main Jun 14, 2024
18 checks passed
@theletterf theletterf deleted the svrnm-patch-3 branch June 14, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants