Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh] add contributing/_index.md #4667

Merged
merged 5 commits into from
Jun 14, 2024

Conversation

darielli
Copy link
Contributor

[zh] add contributing/_index.md

@darielli darielli requested review from a team June 12, 2024 12:00
@darielli
Copy link
Contributor Author

/fix:format

@opentelemetrybot
Copy link
Collaborator

Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide a space between en and zh chars, to follow the style on the current pages.
You need to check from top to bottom, thanks.

content/zh/docs/contributing/_index.md Outdated Show resolved Hide resolved
content/zh/docs/contributing/_index.md Outdated Show resolved Hide resolved
content/zh/docs/contributing/_index.md Outdated Show resolved Hide resolved
content/zh/docs/contributing/_index.md Outdated Show resolved Hide resolved
content/zh/docs/contributing/_index.md Outdated Show resolved Hide resolved
@reyang
Copy link
Member

reyang commented Jun 13, 2024

Could you provide a space between en and zh chars, to follow the style on the current pages. You need to check from top to bottom, thanks.

Maybe a good thing to cover in the CI job.

@chalin chalin force-pushed the contributing-index branch from deaf6da to 4c8f6b6 Compare June 14, 2024 22:26
@chalin chalin force-pushed the contributing-index branch from 4c8f6b6 to ce8b403 Compare June 14, 2024 22:30
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Contributing section has been reworked, but this is consistent with the given commit hash. LGTM, thanks!

@chalin chalin merged commit 787a651 into open-telemetry:main Jun 14, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants