Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opentelemetry-java version to v1.39.0, take 2 #4658

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jun 11, 2024

Followup to:

I can't recall for sure why the change in this PR wasn't included by 4621, other than because the auto-update script had not yet been adjusted yet.

Trigger the auto-version update script has no effect, because it won't submit "duplicate" PRs when one exists already. Hence this manually generated PR.

The only place that I see this variable used is in the Sprint Boot starter > Getting started > Dependency management, in the Maven config. PTAL to confirm that the version value is correct for:

        <dependency>
            <groupId>io.opentelemetry</groupId>
            <artifactId>opentelemetry-bom</artifactId>
            <version>1.39.0</version>
            <type>pom</type>
            <scope>import</scope>
        </dependency>

@chalin chalin requested review from a team June 11, 2024 17:47
@chalin
Copy link
Contributor Author

chalin commented Jun 11, 2024

/cc @zeitlinger @jeanbisutti

@chalin chalin force-pushed the chalin-im-java-vers-update-2024-06-11 branch from 4ae6ce5 to 0e3702b Compare June 12, 2024 08:08
@zeitlinger
Copy link
Member

yes, that's correct

@chalin chalin force-pushed the chalin-im-java-vers-update-2024-06-11 branch from 0e3702b to a4b7666 Compare June 12, 2024 12:30
@chalin chalin merged commit 4b1f5e3 into open-telemetry:main Jun 12, 2024
16 checks passed
@chalin chalin deleted the chalin-im-java-vers-update-2024-06-11 branch June 12, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants