Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further consolidate Contributing guides #4654

Merged
merged 21 commits into from
Jun 13, 2024
Merged

Further consolidate Contributing guides #4654

merged 21 commits into from
Jun 13, 2024

Conversation

theletterf
Copy link
Member

@theletterf theletterf commented Jun 11, 2024 •
edited by chalin
Loading

@theletterf theletterf requested review from a team June 11, 2024 13:22
@theletterf theletterf changed the title Rearrange guide Further consolidate Contributing guides Jun 11, 2024
@theletterf theletterf marked this pull request as draft June 11, 2024 13:37
@theletterf theletterf marked this pull request as ready for review June 11, 2024 14:11
chalin
chalin reviewed Jun 11, 2024
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @theletterf. See inline comments.

README.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@theletterf
Copy link
Member Author

@chalin Ready for a second look!

@theletterf theletterf requested a review from chalin June 12, 2024 09:29
@theletterf theletterf requested a review from svrnm June 13, 2024 07:52
chalin
chalin reviewed Jun 13, 2024
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Still a few more things to reorg / adjust IMHO. See inline comments. I'm ok if you prefer landing this first and keeping the further reorg for a followup PR. My preference would be to address in this PR.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
content/en/docs/contributing/pr-checks.md Outdated Show resolved Hide resolved
content/en/docs/contributing/pr-checks.md Outdated Show resolved Hide resolved
content/en/docs/contributing/requirements.md Outdated Show resolved Hide resolved
content/en/docs/contributing/requirements.md Outdated Show resolved Hide resolved
content/en/docs/contributing/requirements.md Outdated Show resolved Hide resolved
content/en/docs/contributing/requirements.md Show resolved Hide resolved
content/en/docs/contributing/requirements.md Outdated Show resolved Hide resolved
@theletterf theletterf self-assigned this Jun 13, 2024
chalin
chalin approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🙏

@chalin chalin merged commit d78e63a into main Jun 13, 2024
18 checks passed
@chalin chalin deleted the theletterf-consolidate-contributing-guides-further branch June 13, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

@svrnm svrnm Awaiting requested review from svrnm

Assignees

@theletterf theletterf

Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contributing guidelines should be consolidated in one place
3 participants
@theletterf @svrnm @chalin