-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce component owners #4646
Conversation
Signed-off-by: svrnm <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a minor suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I haven't cross checked all of the entries. See inline comments.
FYI, dyladan/component-owners#19 needs to be fixed before we can apply this |
Co-authored-by: Patrice Chalin <[email protected]>
Signed-off-by: svrnm <[email protected]>
FYI, dyladan/component-owners#19 is merged now (thanks @dyladan!) I will rework this PR and make it available asap |
Signed-off-by: svrnm <[email protected]>
fixes #3581
This is a disruptive change, so when we roll it out we should monitor it carefully and roll it back/fix it quickly if anything misbehaves.
@dyladan to verify that, is component-owners compatible with github teams? In your examples I only saw individual usernames