Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce component owners #4646

Merged
merged 8 commits into from
Jul 23, 2024
Merged

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Jun 10, 2024

fixes #3581

This is a disruptive change, so when we roll it out we should monitor it carefully and roll it back/fix it quickly if anything misbehaves.

@dyladan to verify that, is component-owners compatible with github teams? In your examples I only saw individual usernames

@svrnm svrnm requested a review from a team June 10, 2024 15:32
.github/CODEOWNERS Outdated Show resolved Hide resolved
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor suggestion

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I haven't cross checked all of the entries. See inline comments.

.github/workflows/component-owners.yml Outdated Show resolved Hide resolved
.github/workflows/component-owners.yml Outdated Show resolved Hide resolved
.github/component-owners.yml Outdated Show resolved Hide resolved
.github/component-owners.yml Show resolved Hide resolved
@svrnm
Copy link
Member Author

svrnm commented Jun 10, 2024

FYI, dyladan/component-owners#19 needs to be fixed before we can apply this

@svrnm svrnm added blocked CI/infra CI & infrastructure labels Jun 11, 2024
@svrnm svrnm marked this pull request as draft July 4, 2024 08:50
@svrnm
Copy link
Member Author

svrnm commented Jul 17, 2024

FYI, dyladan/component-owners#19 is merged now (thanks @dyladan!) I will rework this PR and make it available asap

@svrnm svrnm removed the blocked label Jul 17, 2024
@svrnm svrnm marked this pull request as ready for review July 23, 2024 08:38
@svrnm svrnm merged commit fcc47d8 into open-telemetry:main Jul 23, 2024
16 checks passed
@svrnm svrnm deleted the component-owners branch July 23, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace CODEOWNERS with component owners
4 participants