Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note about micrometer #4643

Closed

Conversation

zeitlinger
Copy link
Member

No description provided.

@zeitlinger zeitlinger self-assigned this Jun 10, 2024
@zeitlinger zeitlinger requested review from a team June 10, 2024 14:38
@zeitlinger zeitlinger assigned trask and unassigned trask Jun 10, 2024
@zeitlinger zeitlinger requested a review from trask June 10, 2024 14:39
@zeitlinger
Copy link
Member Author

/fix:format

@opentelemetrybot
Copy link
Collaborator

@chalin chalin force-pushed the note-about-micrometer branch from d4e2095 to 96a670e Compare June 10, 2024 19:28
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mention on Slack. I think that the entire content of this section should be moved one level up, into the Java landing page (or it's own Comparing page).

@trask
Copy link
Member

trask commented Jun 10, 2024

As mention on Slack. I think that the entire content of this section should be moved one level up, into the Java landing page (or it's own Comparing page).

I think I prefer its own Comparing page under Spring Boot Starter

@zeitlinger zeitlinger force-pushed the note-about-micrometer branch from f0e1291 to 0bacee0 Compare June 11, 2024 06:03
@zeitlinger
Copy link
Member Author

/fix:format

@opentelemetrybot
Copy link
Collaborator

@svrnm svrnm requested a review from chalin June 11, 2024 07:41
Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's something in adding a recommendation in user docs that is a bit jarring to me (using Spring Boot starter instead of another solution). I think docs should be more neutral. Perhaps the recommendation or even the whole content could go into a blog post. @svrnm What do you reckon?

@zeitlinger
Copy link
Member Author

There's something in adding a recommendation in user docs that is a bit jarring to me (using Spring Boot starter instead of another solution). I think docs should be more neutral. Perhaps the recommendation or even the whole content could go into a blog post. @svrnm What do you reckon?

the tone should be neutral
we keep getting those questions - so it would be helpful to have an easy-to-find answer

@zeitlinger
Copy link
Member Author

/fix:format

@opentelemetrybot
Copy link
Collaborator

@chalin
Copy link
Contributor

chalin commented Jun 11, 2024

Here's a proposal: @zeitlinger make the minor suggested edits, we land this PR, and after that look at moving the content to a dedicated comparing page. WDYT?

@chalin
Copy link
Contributor

chalin commented Jun 11, 2024

100% agree with @theletterf comment about neutrality -- and thanks for bring that up, it had bothered me too.

@chalin
Copy link
Contributor

chalin commented Jun 11, 2024

/fix:refcache

@opentelemetrybot
Copy link
Collaborator

You triggered fix:refcache action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/9464160116

@svrnm
Copy link
Member

svrnm commented Jun 12, 2024

on the topic of neutrality: since this seems to be a frequently asked question it can/should live in the docs not in the blog, I actually think we can have more of that in the future, but key is that the wording is friendly and embracing the other open source solution as well. I will reread the PR under that aspect once again

Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking a closer look under the "neutrality" perspective, see my suggestions.

A general comment: the differences are very high level, so as an end user I might want to know even more. Can we expand on that a little bit (e.g. my understanding is that micrometer is a facade around different metric/tracing solutions ("Micrometer provides a simple facade over the instrumentation clients for the most popular observability systems"), I think that's a key differentiator, if someone thinks they do not want to be "vendor-locked" by opentelemetry, they can have another layer of abstraction.

Comment on lines +47 to +52
As the authors of the OpenTelemetry Spring Boot starter, we recommend using the
OpenTelemetry Spring Boot starter. We have a great community behind it, and are
continuously making improvements. If you try it out and have any problems or
suggestions, open an
[issue](https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues)
in our repository.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
As the authors of the OpenTelemetry Spring Boot starter, we recommend using the
OpenTelemetry Spring Boot starter. We have a great community behind it, and are
continuously making improvements. If you try it out and have any problems or
suggestions, open an
[issue](https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues)
in our repository.
Both solutions are open source and support different exporters, including OTLP and Prometheus,
and both are compatible for tracing use cases. This means, that they fit equally into an existing
observability architecture. It is up to the end user to decide, which solution satisfies their requirements better.

This is the sentence I would remove in the light of "neutrality". It's very obvious that we recommend the otel solution, so we don't have to say that explicitly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds a bit like we would not be convinced that our solution is the better one.

We do try to become the standard API in the java world - can we say that in a friendly way?

Micrometer [^1][^2]:

- An independent standalone observability system.
- Offers optional bridges into parts of the OpenTelemetry ecosystem.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Offers optional bridges into parts of the OpenTelemetry ecosystem.
- Offers optional bridges into OpenTelemetry Tracing and Metrics.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you also don't get SDK features

@zeitlinger
Copy link
Member Author

if someone thinks they do not want to be "vendor-locked" by opentelemetry, they can have another layer of abstraction.

the message of this PR is that you're not locked, because only otel is governed by an independent body

@zeitlinger zeitlinger assigned trask and unassigned zeitlinger Jul 17, 2024
@svrnm
Copy link
Member

svrnm commented Aug 1, 2024

@zeitlinger can we make any progress on this? If I remember correctly @trask wanted to take another look at this?

@zeitlinger
Copy link
Member Author

yes, @trask is still on it

@cartermp
Copy link
Contributor

cartermp commented Nov 2, 2024

Closing out old PR -- I realize we wanted to say something here but it's been a few months, so feel free to re-open if you think it's still worth it

@cartermp cartermp closed this Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Status: In progress
Development

Successfully merging this pull request may close these issues.

7 participants