-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add note about micrometer #4643
Conversation
/fix:format |
You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/9450569700 |
d4e2095
to
96a670e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mention on Slack. I think that the entire content of this section should be moved one level up, into the Java landing page (or it's own Comparing page).
I think I prefer its own Comparing page under Spring Boot Starter |
f0e1291
to
0bacee0
Compare
Co-authored-by: Patrice Chalin <[email protected]>
Co-authored-by: Patrice Chalin <[email protected]>
Co-authored-by: Patrice Chalin <[email protected]>
Co-authored-by: Patrice Chalin <[email protected]>
/fix:format |
You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/9460735466 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's something in adding a recommendation in user docs that is a bit jarring to me (using Spring Boot starter instead of another solution). I think docs should be more neutral. Perhaps the recommendation or even the whole content could go into a blog post. @svrnm What do you reckon?
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
the tone should be neutral |
/fix:format |
You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/9462194586 |
Here's a proposal: @zeitlinger make the minor suggested edits, we land this PR, and after that look at moving the content to a dedicated comparing page. WDYT? |
100% agree with @theletterf comment about neutrality -- and thanks for bring that up, it had bothered me too. |
/fix:refcache |
You triggered fix:refcache action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/9464160116 |
on the topic of neutrality: since this seems to be a frequently asked question it can/should live in the docs not in the blog, I actually think we can have more of that in the future, but key is that the wording is friendly and embracing the other open source solution as well. I will reread the PR under that aspect once again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taking a closer look under the "neutrality" perspective, see my suggestions.
A general comment: the differences are very high level, so as an end user I might want to know even more. Can we expand on that a little bit (e.g. my understanding is that micrometer is a facade around different metric/tracing solutions ("Micrometer provides a simple facade over the instrumentation clients for the most popular observability systems"), I think that's a key differentiator, if someone thinks they do not want to be "vendor-locked" by opentelemetry, they can have another layer of abstraction.
As the authors of the OpenTelemetry Spring Boot starter, we recommend using the | ||
OpenTelemetry Spring Boot starter. We have a great community behind it, and are | ||
continuously making improvements. If you try it out and have any problems or | ||
suggestions, open an | ||
[issue](https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues) | ||
in our repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the authors of the OpenTelemetry Spring Boot starter, we recommend using the | |
OpenTelemetry Spring Boot starter. We have a great community behind it, and are | |
continuously making improvements. If you try it out and have any problems or | |
suggestions, open an | |
[issue](https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues) | |
in our repository. | |
Both solutions are open source and support different exporters, including OTLP and Prometheus, | |
and both are compatible for tracing use cases. This means, that they fit equally into an existing | |
observability architecture. It is up to the end user to decide, which solution satisfies their requirements better. |
This is the sentence I would remove in the light of "neutrality". It's very obvious that we recommend the otel solution, so we don't have to say that explicitly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sounds a bit like we would not be convinced that our solution is the better one.
We do try to become the standard API in the java world - can we say that in a friendly way?
Micrometer [^1][^2]: | ||
|
||
- An independent standalone observability system. | ||
- Offers optional bridges into parts of the OpenTelemetry ecosystem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Offers optional bridges into parts of the OpenTelemetry ecosystem. | |
- Offers optional bridges into OpenTelemetry Tracing and Metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you also don't get SDK features
Co-authored-by: Severin Neumann <[email protected]>
the message of this PR is that you're not locked, because only otel is governed by an independent body |
@zeitlinger can we make any progress on this? If I remember correctly @trask wanted to take another look at this? |
yes, @trask is still on it |
Closing out old PR -- I realize we wanted to say something here but it's been a few months, so feel free to re-open if you think it's still worth it |
No description provided.