-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Java Metric Systems Compared blog post #4512
Merged
svrnm
merged 12 commits into
open-telemetry:main
from
jack-berg:java-metric-systems-compared
May 24, 2024
Merged
Add Java Metric Systems Compared blog post #4512
svrnm
merged 12 commits into
open-telemetry:main
from
jack-berg:java-metric-systems-compared
May 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 21, 2024
trask
reviewed
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I stumbled over thinking "attributes" = "attribute names", so left some suggestions to explicitly use "attribute values" for clarity
svrnm
requested changes
May 23, 2024
svrnm
approved these changes
May 24, 2024
svrnm
reviewed
May 24, 2024
Co-authored-by: Severin Neumann <[email protected]>
Hmm, I'm getting a problem when building locally: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4517.
Hi - I've put together a blog post doing a deep dive into what makes a metric system good, and comparing the performance of
opentelemetry-java
to other popular metrics systems in the java ecosystem.